ci: acn build cil log collector #4211
Draft
+1,998
−792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently puts makefile targets in a separate included makefile, which can be changed currently uses server side apply to apply the cilium log collector sidecar, which can be changed
currently adds cilium log collector only to overlay cilium scenario log collector only available on linux builds and publishes images for cni release and acn pr but only used in acn pr for now files are server side applied and we expect the cilium daemonset to be server side applied first before adding the log collector
the container is host network, so we must use ClusterFirstWithHostNet or dns will fail
if cilium has dnsPolicy ClusterFirstWithHostNet, k8s will add coredns's ip to the pod's /etc/resolv.conf cilium must come up for coredns to come up, but when cilium starts it makes a dns request to core dns as a result of the /etc/resolv.conf specifying core dns's ip. core dns at this point is down, however, and the request times out, so cilium can't start up either ClusterFirst with hostNetwork is actually "default" (uses vm's /etc/resolv.conf, likely 168.63.129.16/azure dns)
ideally we use a filter plugin but there's no go framework for that right now take a dependency on the acn method we use for getting imds info (can be changed) sets kubernetes filter plugin to use tag for pod name etc.; unlike the default setting we can enrich without a connection to core dns/k8s api/kubelet-- this is important because on cilium startup coredns will not be running tested data pipeline through adx in development
…g collector affects: cni release test, acn pr, acn official build, nightly, ebpf host routing/msft cil see what breaks previous commit passes on overlay only
we can try out server side apply with cilium ebpf later-- for now keep as-is
previous commit passes all cni release test, acn pr, acn official build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Add cilium log collector to acn official build/signing
Must be merged in after the main cilium log collector PR is merged in
Issue Fixed:
Requirements:
Notes: