[Az.ServiceFabric] Added parameter AutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedCluster
#28349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the AutoGeneratedDomainNameLabelScope parameter to enable migration to public CA cluster certificates in Service Fabric managed clusters. The changes also include alphabetical reordering of constructor parameters for consistency.
Key changes:
- Added
AutoGeneratedDomainNameLabelScopeparameter toNew-AzServiceFabricManagedClusterandSet-AzServiceFabricManagedClustercmdlets - Updated constructor parameter ordering to alphabetical in both PSManagedCluster and PSManagedNodeType models
- Updated help documentation to include the new parameter
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| NewAzServiceFabricManagedCluster.cs | Added AutoGeneratedDomainNameLabelScope parameter and implementation |
| SetAzServiceFabricManagedCluster.cs | Added AutoGeneratedDomainNameLabelScope parameter and update logic |
| PSManagedCluster.cs | Reordered constructor parameters alphabetically and added new property |
| PSManagedNodeType.cs | Reordered constructor parameters alphabetically |
| New-AzServiceFabricManagedCluster.md | Updated help documentation with new parameter |
| Set-AzServiceFabricManagedCluster.md | Updated help documentation with new parameter |
| ChangeLog.md | Added changelog entry for the new feature |
src/ServiceFabric/ServiceFabric/Models/ManagedClusters/PSManagedCluster.cs
Outdated
Show resolved
Hide resolved
iliu816
changed the title
Set-AzServiceFabricManagedClusterApplication to correctly overwrite existing application upgrade policy when -RecreateApplication parameter is specified and no other upgrade policy parameters are boundAutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedCluster
iliu816
changed the title
AutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedClusterAutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedCluster
iliu816
changed the title
AutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedClusterAutoGeneratedDomainNameLabelScope to allow customers to initiate migration to public CA cluster certificates in cmdlet New-AzServiceFabricManagedCluster and Set-AzServiceFabricManagedCluster
a-santamaria
approved these changes
Aug 8, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed
Set-AzServiceFabricManagedClusterApplicationto correctly overwrite existing application upgrade policy when-RecreateApplicationparameter is specified and no other upgrade policy parameters are bound.Based on instructions at https://eng.ms/docs/products/azure-service-fabric/how-to/publiccacluster/managed-tls-solution
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.