-
Notifications
You must be signed in to change notification settings - Fork 4k
[Az.ContainerInstance] Update generation tool version: autorest.powershell v3->v4 #28376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the autorest.powershell generation tool from version 3 to version 4 for the Az.ContainerInstance module. The update modernizes the SDK generation process and updates parameter handling patterns.
- Updates generation tool to leverage autorest.powershell v4 features
- Consolidates parameter sets and introduces new Json input patterns for update operations
- Modernizes identity management patterns with new EnableSystemAssignedIdentity parameter
Reviewed Changes
Copilot reviewed 89 out of 89 changed files in this pull request and generated 8 comments.
File | Description |
---|---|
tools/StaticAnalysis/Exceptions/Az.ContainerInstance/BreakingChangeIssues.csv | Adds breaking change exceptions for property type changes and parameter patterns |
src/ContainerInstance/ContainerInstance/help/*.md | Updates help documentation with new parameter sets and type references |
src/ContainerInstance/ContainerInstance.Autorest/test/New-AzContainerGroup.Tests.ps1 | Updates test to use new identity parameter pattern |
src/ContainerInstance/ContainerInstance.Autorest/examples/*.md | Updates example usage to reflect new identity management approach |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@@ -9,7 +9,7 @@ schema: 2.0.0 | |||
|
|||
## SYNOPSIS | |||
Restarts all containers in a container group in place. | |||
If container image has updates, new image will be downloaded. | |||
If container image has restart new image will be downloaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a word missing in this line. It should read 'If container image has updates, new image will be downloaded.' The word 'updates' seems to have been replaced with 'restart' incorrectly.
If container image has restart new image will be downloaded. | |
If container image has updates, new image will be downloaded. |
Copilot uses AI. Check for mistakes.
@@ -28,7 +28,7 @@ Restart-AzContainerGroup -InputObject <IContainerInstanceIdentity> [-DefaultProf | |||
|
|||
## DESCRIPTION | |||
Restarts all containers in a container group in place. | |||
If container image has updates, new image will be downloaded. | |||
If container image has restart new image will be downloaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as above - 'restart' should be 'updates' for consistency and correctness.
If container image has restart new image will be downloaded. | |
If the container image has updates, the new image will be downloaded. |
Copilot uses AI. Check for mistakes.
This command updates a container group profile using pipeing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'pipeing' is misspelled. It should be 'piping'.
This command updates a container group profile using pipeing. | |
This command updates a container group profile using piping. |
Copilot uses AI. Check for mistakes.
@@ -26,5 +26,5 @@ AdditionalProperties : {[k, v]} | |||
Count : 1 | |||
``` | |||
|
|||
This command updates a container group using piping. | |||
This command updates a container group using pipeing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'pipeing' is misspelled. It should be 'piping'.
This command updates a container group using pipeing. | |
This command updates a container group using piping. |
Copilot uses AI. Check for mistakes.
@@ -72,7 +86,7 @@ AdditionalProperties : {[k, v]} | |||
Count : 1 | |||
``` | |||
|
|||
This command updates a container group profile using piping. | |||
This command updates a container group profile using pipeing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'pipeing' is misspelled. It should be 'piping'.
This command updates a container group profile using pipeing. | |
This command updates a container group profile using piping. |
Copilot uses AI. Check for mistakes.
@@ -58,7 +70,7 @@ AdditionalProperties : {[k, v]} | |||
Count : 1 | |||
``` | |||
|
|||
This command updates a container group using piping. | |||
This command updates a container group using pipeing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'pipeing' is misspelled. It should be 'piping'.
This command updates a container group using pipeing. | |
This command updates a container group using piping. |
Copilot uses AI. Check for mistakes.
@@ -9,7 +9,7 @@ schema: 2.0.0 | |||
|
|||
## SYNOPSIS | |||
Restarts all containers in a container group in place. | |||
If container image has updates, new image will be downloaded. | |||
If container image has restart new image will be downloaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a word missing or incorrect in this line. It should read 'If container image has updates, new image will be downloaded.' The word 'updates' seems to have been replaced with 'restart' incorrectly.
If container image has restart new image will be downloaded. | |
If container image has updates, new image will be downloaded. |
Copilot uses AI. Check for mistakes.
@@ -27,7 +27,7 @@ Restart-AzContainerGroup -InputObject <IContainerInstanceIdentity> [-DefaultProf | |||
|
|||
## DESCRIPTION | |||
Restarts all containers in a container group in place. | |||
If container image has updates, new image will be downloaded. | |||
If container image has restart new image will be downloaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as above - 'restart' should be 'updates' for consistency and correctness.
If container image has restart new image will be downloaded. | |
If the container image has updates, a new image will be downloaded. |
Copilot uses AI. Check for mistakes.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
To the author of the pull request, |
To the author of the pull request, |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.