-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Hub Generated] Review request for Microsoft.Monitor to add version stable/2023-04-03 #23107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ArcturusZhang
merged 43 commits into
main
from
jasondavis-MS-monitor-Microsoft.Monitor-2023-04-03
Apr 18, 2023
Merged
Changes from 14 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
aea270e
Adds base for updating Microsoft.Monitor from version preview/2021-06…
jasondavis-MS 896a3a3
Updates readme
jasondavis-MS 3c6fffc
Updates API version in new specs and examples
jasondavis-MS 2e2eaef
add publicNetworkAccess
jasondavis-MS 4f7a009
add PrivateEndpointConnections
jasondavis-MS 4674d93
add PrivateEndpointConnections subclasses
jasondavis-MS ea9dd89
give PrivateEndpointConnectionProperties.ProvisioningState enum vals
jasondavis-MS baa9fbb
give publicNetworkAccess an enum
jasondavis-MS de7cab4
add privateEndpointConnections and publicNetworkAccess to Create example
jasondavis-MS 76906f8
add PrivateEndpointConnection and PublicNetworkAccess to other examples
jasondavis-MS b62df79
attempt to fix XmsIdentifierValidation linter error
jasondavis-MS 3cf06e5
attempt to fix ArrayMustHaveType linter error
jasondavis-MS b773ed0
attempt to fix XmsEnumValidation and retry XmsIdentifierValidation er…
jasondavis-MS c89f963
attempt to fix MISSING_APIS_IN_DEFAULT_TAG
jasondavis-MS 9d548d0
use common-type for PrivateEndpointConnection ref, remove nested fields
jasondavis-MS c0b1031
update Create and Delete responses for async operations
jasondavis-MS c9c17da
further async update
jasondavis-MS 671a594
Revert "further async update"
jasondavis-MS 4720e43
Revert "update Create and Delete responses for async operations"
jasondavis-MS 2043102
remove 201 from Create, 200 and 204 from Delete, add 202 to Delete
jasondavis-MS 7ea8171
readd 204 to Delete
jasondavis-MS 3b77b5b
make corresponding response updates to API
jasondavis-MS f539c36
add x-ms-long-running-operation: true to Delete
jasondavis-MS 63f568b
add x-ms-long-running-operation-options for Delete
jasondavis-MS 6bd3979
try to fix Lro errors
jasondavis-MS 42562f8
try to fix errors
jasondavis-MS 39e3b10
try to fix errors
jasondavis-MS 9c725fa
attempt fix again
jasondavis-MS 5011d28
try again
jasondavis-MS 9c4c655
continue
jasondavis-MS 899d6b1
continue
jasondavis-MS 1622644
once more
jasondavis-MS d08031d
another try
jasondavis-MS 649bc7e
last one for real
jasondavis-MS 72950f5
last one v2
jasondavis-MS f7edcdc
just one more
jasondavis-MS 4f28a31
last or second to last one, guaranteed
jasondavis-MS 0fc498f
attempt cleanup
jasondavis-MS 4bf85ca
Revert "attempt cleanup"
jasondavis-MS 31944e2
reintroduce 201 response for PUT
jasondavis-MS 09319ca
remove double readme entry
jamlai efd1402
resolve Go SDK duplication schema issue
tadelesh 58daca2
revert change
tadelesh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
90 changes: 90 additions & 0 deletions
90
...ce-manager/Microsoft.Monitor/stable/2023-04-03/examples/AzureMonitorWorkspacesCreate.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "703362b3-f278-4e4b-9179-c76eaf41ffc2", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "azureMonitorWorkspaceName": "myAzureMonitorWorkspace", | ||
| "api-version": "2023-04-03", | ||
| "azureMonitorWorkspaceProperties": { | ||
| "location": "eastus" | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace", | ||
| "name": "myAzureMonitorWorkspace", | ||
| "type": "Microsoft.Monitor/accounts", | ||
| "location": "eastus", | ||
| "tags": { | ||
| "tag1": "A", | ||
| "tag2": "B" | ||
| }, | ||
| "properties": { | ||
| "accountId": "2df515bf-c3ce-4920-84d4-1d9d16542d9f", | ||
| "metrics": { | ||
| "prometheusQueryEndpoint": "https://myAzureMonitorWorkspace-v8hx.eastus.prometheus.monitor.azure.com", | ||
| "internalId": "mac_2df515bf-c3ce-4920-84d4-1d9d16542d9f" | ||
| }, | ||
| "provisioningState": "Succeeded", | ||
| "defaultIngestionSettings": { | ||
| "dataCollectionRuleResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionRules/myAzureMonitorWorkspace", | ||
| "dataCollectionEndpointResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionEndpoints/myAzureMonitorWorkspace" | ||
| }, | ||
| "privateEndpointConnections": [ | ||
| { | ||
| "id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace/privateEndpointConnections/myPrivateEndpointConnection", | ||
| "name": "myPrivateEndpointConnection", | ||
| "type": "Microsoft.Monitor/accounts/privateEndpointConnections", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "privateEndpoint": { | ||
| "id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/myPrivateEndpointConnection" | ||
| }, | ||
| "groupIds": [ | ||
| "prometheusMetrics" | ||
| ], | ||
| "privateLinkServiceConnectionState": { | ||
| "status": "Approved", | ||
| "description": "Auto-approved", | ||
| "actionsRequired": "None" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "publicNetworkAccess": "Enabled" | ||
| }, | ||
| "systemData": { | ||
| "createdBy": "user1", | ||
| "createdByType": "User", | ||
| "createdAt": "2021-04-01T12:34:56.1234567Z", | ||
| "lastModifiedBy": "user2", | ||
| "lastModifiedByType": "User", | ||
| "lastModifiedAt": "2021-04-02T12:34:56.1234567Z" | ||
| }, | ||
| "etag": "070057da-0000-0000-0000-5ba70d6c0000" | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace", | ||
| "name": "myAzureMonitorWorkspace", | ||
| "type": "Microsoft.Monitor/accounts", | ||
| "location": "eastus", | ||
| "tags": { | ||
| "tag1": "A", | ||
| "tag2": "B" | ||
| }, | ||
| "properties": {}, | ||
| "systemData": { | ||
| "createdBy": "user1", | ||
| "createdByType": "User", | ||
| "createdAt": "2021-04-01T12:34:56.1234567Z", | ||
| "lastModifiedBy": "user2", | ||
| "lastModifiedByType": "User", | ||
| "lastModifiedAt": "2021-04-02T12:34:56.1234567Z" | ||
| }, | ||
| "etag": "070057da-0000-0000-0000-5ba70d6c0000" | ||
| } | ||
| } | ||
| } | ||
| } | ||
12 changes: 12 additions & 0 deletions
12
...ce-manager/Microsoft.Monitor/stable/2023-04-03/examples/AzureMonitorWorkspacesDelete.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "703362b3-f278-4e4b-9179-c76eaf41ffc2", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "azureMonitorWorkspaceName": "myAzureMonitorWorkspace", | ||
| "api-version": "2023-04-03" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
jasondavis-MS marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "204": {} | ||
| } | ||
| } | ||
65 changes: 65 additions & 0 deletions
65
...ource-manager/Microsoft.Monitor/stable/2023-04-03/examples/AzureMonitorWorkspacesGet.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "703362b3-f278-4e4b-9179-c76eaf41ffc2", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "azureMonitorWorkspaceName": "myAzureMonitorWorkspace", | ||
| "api-version": "2023-04-03" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace", | ||
| "name": "myAzureMonitorWorkspace", | ||
| "type": "Microsoft.Monitor/accounts", | ||
| "location": "eastus", | ||
| "tags": { | ||
| "tag1": "A", | ||
| "tag2": "B" | ||
| }, | ||
| "properties": { | ||
| "accountId": "2df515bf-c3ce-4920-84d4-1d9d16542d9f", | ||
| "metrics": { | ||
| "prometheusQueryEndpoint": "https://myAzureMonitorWorkspace-v8hx.eastus.prometheus.monitor.azure.com", | ||
| "internalId": "mac_2df515bf-c3ce-4920-84d4-1d9d16542d9f" | ||
| }, | ||
| "provisioningState": "Succeeded", | ||
| "defaultIngestionSettings": { | ||
| "dataCollectionRuleResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionRules/myAzureMonitorWorkspace", | ||
| "dataCollectionEndpointResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionEndpoints/myAzureMonitorWorkspace" | ||
| }, | ||
| "privateEndpointConnections": [ | ||
| { | ||
| "id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace/privateEndpointConnections/myPrivateEndpointConnection", | ||
| "name": "myPrivateEndpointConnection", | ||
| "type": "Microsoft.Monitor/accounts/privateEndpointConnections", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "privateEndpoint": { | ||
| "id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/myPrivateEndpointConnection" | ||
| }, | ||
| "groupIds": [ | ||
| "prometheusMetrics" | ||
| ], | ||
| "privateLinkServiceConnectionState": { | ||
| "status": "Approved", | ||
| "description": "Auto-approved", | ||
| "actionsRequired": "None" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "publicNetworkAccess": "Enabled" | ||
| }, | ||
| "systemData": { | ||
| "createdBy": "user1", | ||
| "createdByType": "User", | ||
| "createdAt": "2021-04-01T12:34:56.1234567Z", | ||
| "lastModifiedBy": "user2", | ||
| "lastModifiedByType": "User", | ||
| "lastModifiedAt": "2021-04-02T12:34:56.1234567Z" | ||
| }, | ||
| "etag": "070057da-0000-0000-0000-5ba70d6c0000" | ||
| } | ||
| } | ||
| } | ||
| } |
122 changes: 122 additions & 0 deletions
122
...crosoft.Monitor/stable/2023-04-03/examples/AzureMonitorWorkspacesListByResourceGroup.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "703362b3-f278-4e4b-9179-c76eaf41ffc2", | ||
| "resourceGroupName": "myResourceGroup", | ||
| "api-version": "2023-04-03" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace", | ||
| "name": "myAzureMonitorWorkspace", | ||
| "type": "Microsoft.Monitor/accounts", | ||
| "location": "eastus", | ||
| "tags": { | ||
| "tag1": "A", | ||
| "tag2": "B" | ||
| }, | ||
| "properties": { | ||
| "accountId": "2df515bf-c3ce-4920-84d4-1d9d16542d9f", | ||
| "metrics": { | ||
| "prometheusQueryEndpoint": "https://myAzureMonitorWorkspace-abcd.eastus.prometheus.monitor.azure.com", | ||
| "internalId": "mac_2df515bf-c3ce-4920-84d4-1d9d16542d9f" | ||
| }, | ||
| "provisioningState": "Succeeded", | ||
| "defaultIngestionSettings": { | ||
| "dataCollectionRuleResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionRules/myAzureMonitorWorkspace", | ||
| "dataCollectionEndpointResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_myAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionEndpoints/myAzureMonitorWorkspace" | ||
| }, | ||
| "privateEndpointConnections": [ | ||
| { | ||
| "id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace/privateEndpointConnections/myPrivateEndpointConnection", | ||
| "name": "myPrivateEndpointConnection", | ||
| "type": "Microsoft.Monitor/accounts/privateEndpointConnections", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "privateEndpoint": { | ||
| "id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/myPrivateEndpointConnection" | ||
| }, | ||
| "groupIds": [ | ||
| "prometheusMetrics" | ||
| ], | ||
| "privateLinkServiceConnectionState": { | ||
| "status": "Approved", | ||
| "description": "Auto-approved", | ||
| "actionsRequired": "None" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "publicNetworkAccess": "Enabled" | ||
| }, | ||
| "systemData": { | ||
| "createdBy": "user1", | ||
| "createdByType": "User", | ||
| "createdAt": "2021-04-01T12:34:56.1234567Z", | ||
| "lastModifiedBy": "user2", | ||
| "lastModifiedByType": "User", | ||
| "lastModifiedAt": "2021-04-02T12:34:56.1234567Z" | ||
| }, | ||
| "etag": "070057da-0000-0000-0000-5ba70d6c0000" | ||
| }, | ||
| { | ||
| "id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/herAzureMonitorWorkspace", | ||
| "name": "herAzureMonitorWorkspace", | ||
| "type": "Microsoft.Monitor/accounts", | ||
| "location": "westus", | ||
| "tags": { | ||
| "tag1": "A", | ||
| "tag2": "B" | ||
| }, | ||
| "properties": { | ||
| "accountId": "823220c6-0415-44d8-bfb2-d5c1c9ea1172", | ||
| "metrics": { | ||
| "prometheusQueryEndpoint": "https://herAzureMonitorWorkspace-xywz.eastus.prometheus.monitor.azure.com", | ||
| "internalId": "mac_823220c6-0415-44d8-bfb2-d5c1c9ea1172" | ||
| }, | ||
| "provisioningState": "Succeeded", | ||
| "defaultIngestionSettings": { | ||
| "dataCollectionRuleResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_herAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionRules/herAzureMonitorWorkspace", | ||
| "dataCollectionEndpointResourceId": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/MA_herAzureMonitorWorkspace_eastus_managed/providers/Microsoft.Insights/dataCollectionEndpoints/herAzureMonitorWorkspace" | ||
| }, | ||
| "privateEndpointConnections": [ | ||
| { | ||
| "id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Monitor/accounts/myAzureMonitorWorkspace/privateEndpointConnections/myPrivateEndpointConnection", | ||
| "name": "myPrivateEndpointConnection", | ||
| "type": "Microsoft.Monitor/accounts/privateEndpointConnections", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "privateEndpoint": { | ||
| "id": "/subscriptions/703362b3-f278-4e4b-9179-c76eaf41ffc2/resourceGroups/myResourceGroup/providers/Microsoft.Network/privateEndpoints/myPrivateEndpointConnection" | ||
| }, | ||
| "groupIds": [ | ||
| "prometheusMetrics" | ||
| ], | ||
| "privateLinkServiceConnectionState": { | ||
| "status": "Approved", | ||
| "description": "Auto-approved", | ||
| "actionsRequired": "None" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "publicNetworkAccess": "Enabled" | ||
| }, | ||
| "systemData": { | ||
| "createdBy": "user1", | ||
| "createdByType": "User", | ||
| "createdAt": "2021-04-01T12:34:56.1234567Z", | ||
| "lastModifiedBy": "user2", | ||
| "lastModifiedByType": "User", | ||
| "lastModifiedAt": "2021-04-02T12:34:56.1234567Z" | ||
| }, | ||
| "etag": "070057da-0000-0000-0000-5ba70d6c0000" | ||
| } | ||
| ], | ||
| "nextLink": null | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.