Skip to content

Conversation

@koderjoker
Copy link
Member

@koderjoker koderjoker commented Apr 20, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @koderjoker Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 10 Errors, 27 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    redis.json 2023-05-01(bce1160) 2022-06-01(main)
    redis.json 2023-05-01(bce1160) 2019-07-01(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L760:9
    Old: Microsoft.Cache/stable/2022-06-01/redis.json#L818:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L806:9
    Old: Microsoft.Cache/stable/2022-06-01/redis.json#L866:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L869:9
    Old: Microsoft.Cache/stable/2022-06-01/redis.json#L937:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L917:9
    Old: Microsoft.Cache/stable/2022-06-01/redis.json#L993:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L967:9
    Old: Microsoft.Cache/stable/2022-06-01/redis.json#L1057:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L1432:9
    Old: Microsoft.Cache/stable/2022-06-01/redis.json#L1547:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L1477:9
    Old: Microsoft.Cache/stable/2022-06-01/redis.json#L1600:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L1521:9
    Old: Microsoft.Cache/stable/2022-06-01/redis.json#L1652:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L1579:9
    Old: Microsoft.Cache/stable/2022-06-01/redis.json#L1718:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L1624:9
    Old: Microsoft.Cache/stable/2022-06-01/redis.json#L1771:11


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/listUpgradeNotifications' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L103:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L155:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L354:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/Redis' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L394:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/listKeys' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L427:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/regenerateKey' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L471:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/forceReboot' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L524:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/import' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L577:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/export' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L634:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/firewallRules' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L691:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/firewallRules/{ruleName}' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L739:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{cacheName}/patchSchedules' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L906:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/patchSchedules/{default}' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L954:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/linkedServers/{linkedServerName}' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1142:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cache/Redis/{name}/linkedServers' removed or restructured?
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1304:5
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L61:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L106:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'string'.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L2278:11
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'string'.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L2278:11
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'string'.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L2278:11
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
    ⚠️ 1026 - TypeChanged The new version has a different type '' than the previous one 'string'.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L2278:11
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1397:11
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L2285:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L2285:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L2285:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
    ⚠️ 1027 - DefaultValueChanged The new version has a different default value than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L2285:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1402:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L2281:9
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1485:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.Cache/preview/2023-05-01/redis.json#L2566:5
    Old: Microsoft.Cache/preview/2019-07-01/redis.json#L1708:5
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2023-05 package-preview-2023-05(bce1160) package-preview-2023-05(release-redis-Microsoft.Cache-2023-05-01)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Cache/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L57
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Cache/CheckNameAvailability'
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L73
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L173
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L285
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L299
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L333
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L630
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L670
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L689
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L729
    ResourceNameRestriction The resource name parameter 'ruleName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L793
    TrackedResourcePatchOperation Tracked resource 'RedisPatchSchedule' must have patch operation that at least supports the update of tags.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L1000
    ResourceNameRestriction The resource name parameter 'linkedServerName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L1194
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L1195
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L1262
    GetCollectionResponseSchema The response in the GET collection operation 'PrivateEndpointConnections_List' does not match the response definition in the individual GET operation 'PrivateEndpointConnections_Get' .
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L1420
    ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L1465
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L1509
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L1708
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L1934
    MissingTypeObject The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L2161
    MissingTypeObject The schema 'RedisCommonProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L2201
    MissingTypeObject The schema 'RedisCreateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L2342
    MissingTypeObject The schema 'RedisUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L2374
    MissingTypeObject The schema 'RedisProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L2389
    ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L2391
    MissingTypeObject The schema 'RedisCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L2472
    MissingTypeObject The schema 'RedisUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L2512
    MissingTypeObject The schema 'RedisAccessKeys' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L2533
    MissingTypeObject The schema 'RedisFirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Cache/preview/2023-05-01/redis.json#L2548
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Redis Cache label Apr 20, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2023

    Swagger Generation Artifacts

    ️🔄ApiDocPreview inProgress [Detail]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from a17d67a2d3078be2faf465df54314631392e71b1. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Redis [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from a17d67a2d3078be2faf465df54314631392e71b1. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.5
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.5>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-redis [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group AccessPolicyAssignmentOperations
      info	[Changelog]   - Added operation group AccessPolicyOperations
      info	[Changelog]   - Model RedisCommonPropertiesRedisConfiguration has a new parameter aad_enabled
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from a17d67a2d3078be2faf465df54314631392e71b1. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-redis-generated [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from a17d67a2d3078be2faf465df54314631392e71b1. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/redis/armredis [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `AccessPolicyAssignmentProvisioningState` with values `AccessPolicyAssignmentProvisioningStateCanceled`, `AccessPolicyAssignmentProvisioningStateDeleted`, `AccessPolicyAssignmentProvisioningStateDeleting`, `AccessPolicyAssignmentProvisioningStateFailed`, `AccessPolicyAssignmentProvisioningStateSucceeded`, `AccessPolicyAssignmentProvisioningStateUpdating`
      info	[Changelog] - New enum type `AccessPolicyProvisioningState` with values `AccessPolicyProvisioningStateCanceled`, `AccessPolicyProvisioningStateDeleted`, `AccessPolicyProvisioningStateDeleting`, `AccessPolicyProvisioningStateFailed`, `AccessPolicyProvisioningStateSucceeded`, `AccessPolicyProvisioningStateUpdating`
      info	[Changelog] - New enum type `AccessPolicyType` with values `AccessPolicyTypeBuiltIn`, `AccessPolicyTypeCustom`
      info	[Changelog] - New function `NewAccessPolicyAssignmentClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AccessPolicyAssignmentClient, error)`
      info	[Changelog] - New function `*AccessPolicyAssignmentClient.BeginCreateUpdate(context.Context, string, string, string, CacheAccessPolicyAssignmentSet, *AccessPolicyAssignmentClientBeginCreateUpdateOptions) (*runtime.Poller[AccessPolicyAssignmentClientCreateUpdateResponse], error)`
      info	[Changelog] - New function `*AccessPolicyAssignmentClient.BeginDelete(context.Context, string, string, string, *AccessPolicyAssignmentClientBeginDeleteOptions) (*runtime.Poller[AccessPolicyAssignmentClientDeleteResponse], error)`
      info	[Changelog] - New function `*AccessPolicyAssignmentClient.Get(context.Context, string, string, string, *AccessPolicyAssignmentClientGetOptions) (AccessPolicyAssignmentClientGetResponse, error)`
      info	[Changelog] - New function `*AccessPolicyAssignmentClient.NewListPager(string, string, *AccessPolicyAssignmentClientListOptions) *runtime.Pager[AccessPolicyAssignmentClientListResponse]`
      info	[Changelog] - New function `NewAccessPolicyClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AccessPolicyClient, error)`
      info	[Changelog] - New function `*AccessPolicyClient.BeginCreateUpdate(context.Context, string, string, string, CacheAccessPolicy, *AccessPolicyClientBeginCreateUpdateOptions) (*runtime.Poller[AccessPolicyClientCreateUpdateResponse], error)`
      info	[Changelog] - New function `*AccessPolicyClient.BeginDelete(context.Context, string, string, string, *AccessPolicyClientBeginDeleteOptions) (*runtime.Poller[AccessPolicyClientDeleteResponse], error)`
      info	[Changelog] - New function `*AccessPolicyClient.Get(context.Context, string, string, string, *AccessPolicyClientGetOptions) (AccessPolicyClientGetResponse, error)`
      info	[Changelog] - New function `*AccessPolicyClient.NewListPager(string, string, *AccessPolicyClientListOptions) *runtime.Pager[AccessPolicyClientListResponse]`
      info	[Changelog] - New function `*ClientFactory.NewAccessPolicyAssignmentClient() *AccessPolicyAssignmentClient`
      info	[Changelog] - New function `*ClientFactory.NewAccessPolicyClient() *AccessPolicyClient`
      info	[Changelog] - New struct `CacheAccessPolicy`
      info	[Changelog] - New struct `CacheAccessPolicyAssignment`
      info	[Changelog] - New struct `CacheAccessPolicyAssignmentList`
      info	[Changelog] - New struct `CacheAccessPolicyAssignmentSet`
      info	[Changelog] - New struct `CacheAccessPolicyAssignmentSetProperties`
      info	[Changelog] - New struct `CacheAccessPolicyList`
      info	[Changelog] - New struct `CacheAccessPolicyProperties`
      info	[Changelog] - New field `AADEnabled` in struct `CommonPropertiesRedisConfiguration`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 44 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from a17d67a2d3078be2faf465df54314631392e71b1. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-rediscache [View full logs]  [Preview SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group AccessPolicy
      info	[Changelog]   - Added operation group AccessPolicyAssignment
      info	[Changelog]   - Added Interface AccessPolicyAssignmentCreateUpdateOptionalParams
      info	[Changelog]   - Added Interface AccessPolicyAssignmentDeleteHeaders
      info	[Changelog]   - Added Interface AccessPolicyAssignmentDeleteOptionalParams
      info	[Changelog]   - Added Interface AccessPolicyAssignmentGetOptionalParams
      info	[Changelog]   - Added Interface AccessPolicyAssignmentListNextOptionalParams
      info	[Changelog]   - Added Interface AccessPolicyAssignmentListOptionalParams
      info	[Changelog]   - Added Interface AccessPolicyCreateUpdateOptionalParams
      info	[Changelog]   - Added Interface AccessPolicyDeleteHeaders
      info	[Changelog]   - Added Interface AccessPolicyDeleteOptionalParams
      info	[Changelog]   - Added Interface AccessPolicyGetOptionalParams
      info	[Changelog]   - Added Interface AccessPolicyListNextOptionalParams
      info	[Changelog]   - Added Interface AccessPolicyListOptionalParams
      info	[Changelog]   - Added Interface LinkedServerDeleteHeaders
      info	[Changelog]   - Added Interface RedisCacheAccessPolicy
      info	[Changelog]   - Added Interface RedisCacheAccessPolicyAssignment
      info	[Changelog]   - Added Interface RedisCacheAccessPolicyAssignmentList
      info	[Changelog]   - Added Interface RedisCacheAccessPolicyAssignmentSet
      info	[Changelog]   - Added Interface RedisCacheAccessPolicyList
      info	[Changelog]   - Added Type Alias AccessPolicyAssignmentCreateUpdateResponse
      info	[Changelog]   - Added Type Alias AccessPolicyAssignmentGetResponse
      info	[Changelog]   - Added Type Alias AccessPolicyAssignmentListNextResponse
      info	[Changelog]   - Added Type Alias AccessPolicyAssignmentListResponse
      info	[Changelog]   - Added Type Alias AccessPolicyAssignmentProvisioningState
      info	[Changelog]   - Added Type Alias AccessPolicyCreateUpdateResponse
      info	[Changelog]   - Added Type Alias AccessPolicyGetResponse
      info	[Changelog]   - Added Type Alias AccessPolicyListNextResponse
      info	[Changelog]   - Added Type Alias AccessPolicyListResponse
      info	[Changelog]   - Added Type Alias AccessPolicyProvisioningState
      info	[Changelog]   - Added Type Alias AccessPolicyType
      info	[Changelog]   - Interface RedisCommonPropertiesRedisConfiguration has a new optional parameter aadEnabled
      info	[Changelog]   - Added Enum KnownAccessPolicyAssignmentProvisioningState
      info	[Changelog]   - Added Enum KnownAccessPolicyProvisioningState
      info	[Changelog]   - Added Enum KnownAccessPolicyType
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from a17d67a2d3078be2faf465df54314631392e71b1. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from a17d67a2d3078be2faf465df54314631392e71b1. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.redis.DefaultTag [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Swagger Microsoft.Cache https://apiview.dev/Assemblies/Review/e4da641155c74d67adc380b65c7ae32c
    Go sdk/resourcemanager/redis/armredis https://apiview.dev/Assemblies/Review/de48c12e912c4035a9f54d2cf9bfbc34
    Java azure-resourcemanager-redis-generated https://apiview.dev/Assemblies/Review/0a5a20e1385946c09075c18731009c4f
    .Net Azure.ResourceManager.Redis https://apiview.dev/Assemblies/Review/6f4d9c82bae246f186f4e456f34159c0
    JavaScript @azure/arm-rediscache https://apiview.dev/Assemblies/Review/066dd2c025f14e23a5c7b84e6e67b5f5

    @koderjoker
    Copy link
    Member Author

    @qiaozha I've updated the example name as requested in this PR #23406 by @TimLovellSmith. Could you merge this in as soon as possible so that we could merge our release branch into main?

    The lint diff error in this PR is a false alarm for PUT requests and the breaking changes have already been approved as part of this PR #22946

    @openapi-workflow-bot
    Copy link

    Hi @koderjoker, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @zedy-wj
    Copy link
    Member

    zedy-wj commented Apr 21, 2023

    @qiaozha Approved as breaking changes have already been approved as part of this PR #22946.

    @qiaozha qiaozha merged commit 036139d into Azure:release-redis-Microsoft.Cache-2023-05-01 Apr 21, 2023
    @qiaozha qiaozha added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 27, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required Redis Cache resource-manager

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants