Sdixit/aks resources fleet gates typespec and swagger files #38219
Conversation
Supriya-R-Dixit
requested review from
Kishp01,
rajeshka and
shankarsama
as code owners
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
|
PublishToCustomers |
Hi @Supriya-R-Dixit, |
Supriya-R-Dixit
added
the
PublishToCustomers
rajeshka
left a comment
rajeshka
left a comment
There was a problem hiding this comment.
Verified - All the APIViews links are accessible.
### Packages impacted by this PR @azure/eventgrid-systemevents ### Issues associated with this PR Azure/azure-rest-api-specs#38219 Co-authored-by: Rajesh Kamath <a>
...grid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.ResourceNotifications/AKSResources.tsp
Show resolved
Hide resolved
jhendrixMSFT
left a comment
jhendrixMSFT
left a comment
There was a problem hiding this comment.
Need to update Aks -> AKS.
Added AKS resource event data client name overrides for Go.
| @example(MicrosoftResourceNotificationsAKSResourcesFleetGateDeletedExample) | ||
| model ResourceNotificationsAksResourcesFleetGateDeletedEventData { | ||
| /** resourceInfo details for deleted event */ | ||
| resourceInfo: { |
There was a problem hiding this comment.
@tadelesh are we able to rename this type via @clientName?
There was a problem hiding this comment.
I have made the changes in the file "propertyNameOverrideGo.tsp"
Is this where you are expecting this change to be made?
There was a problem hiding this comment.
After thinking about it more, I think the issue here is that the synthesized name is created before the clientName decorator is applied. Is that expected?
There was a problem hiding this comment.
In TypeSpec, we have no way to decorate a model expression, thus @clientName could not be applied to such cases. @
Supriya-R-Dixit Is it possible to give a name for this inline model? Defining anonymous model is not encouraged in Azure.
5 participants
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.