Skip to content

Conversation

@v-xuto
Copy link
Member

@v-xuto v-xuto commented Nov 14, 2025

This PR migrates the search specification to the new unified folder structure according to Azure folder structure guidelines.

Change:

  • Consolidated TypeSpec and Swagger files under
├── data-plane                   
│   ├── Search
│   ├── SearchData
│   └── SearchService 
└── resource-manager/Microsoft.Search/Search
  • Updated tspconfig.yaml with correct paths and ARM types directory
  • Fixed all common-types references and input-file paths in readme.md
  • Added suppressions.yaml for legacy API versions
  • Verified TypeSpec compilation works correctly
  • Updated the relevant paths in cspell.yaml file

Benefits:

  • Unified structure for better maintainability
  • Aligns with Azure folder structure standards
  • Maintains backward compatibility
  • Supports future TypeSpec migration efforts

@v-xuto v-xuto added the FolderMigrationV2 A specific label for PRs like folder structure migration into v2. label Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).


Comment generated by summarize-checks workflow run.

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.Search-Search
Swagger Search-Search
Swagger Search-SearchData
Swagger Search-SearchService
Go sdk/resourcemanager/search/armsearch
Java com.azure.resourcemanager:azure-resourcemanager-searchsearch
Python azure-mgmt-search
JavaScript @azure/arm-search

@github-actions github-actions bot added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required BreakingChange-Python-Sdk BreakingChange-JavaScript-Sdk labels Nov 14, 2025
@v-xuto v-xuto force-pushed the search-folder-structure-refactor branch from 6990430 to 0ffb4fb Compare November 17, 2025 07:36
@v-xuto
Copy link
Member Author

v-xuto commented Nov 17, 2025

Added label to suppress the Swagger SemanticValidation ci error. This error is not thrown by the latest version.
image

@github-actions github-actions bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 18, 2025
@v-xuto v-xuto added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado Approved-LintDiff Approved-ModelValidation Approved-SemanticValidation Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane FolderMigrationV2 A specific label for PRs like folder structure migration into v2. resource-manager SuppressionReviewRequired

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant