Should keyvault be in sdk/security or sdk/keyvault ?

[antkmsft]

In Go, keyvault is located in sdk/security.

In Rust and C++, it is located in sdk/keyvault.

I am going to open an issue for all 3 repos, if we want some consistency.

• C++: Should keyvault be in sdk/security or sdk/keyvault ? azure-sdk-for-cpp#6412
• Rust: Should keyvault be in sdk/security or sdk/keyvault ? azure-sdk-for-rust#2126

See also #24098 (same question about messaging/eventhubs)

[github-actions]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @cheathamb36 @chen-karen @lgonsoulin @vickm.

[jhendrixMSFT]

This is because, for Go, the repo path has a direct impact on a module's identity. e.g. for azkeys customers use the following import.

import github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azkeys

The module identity is related to the source layout in github. And since we wanted the KV modules under security we had to include this segment in the directory structure.

For Rust, since SDKs are referenced by crates, the source directory structure isn't as important, and I believe we're omitting the security segment from the sources there.

If C++ SDKs are source-referenced (I believe they are), then yeah we should figure out what we want it to be.

I suggest we have those conversations in the issues for the relevant languages and close this one.

cc @JeffreyRichter @LarryOsterman

[RickWinter]

Go uses a unique folder structure b/c the git structure matters for inports. Other languages such as C++, Rust, .NET, ... do not need to do this and thus they have the sdk/ pattern with defined within packages as namespaces.