Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should keyvault be in sdk/security or sdk/keyvault ? #2126

Closed
antkmsft opened this issue Feb 12, 2025 · 1 comment
Closed

Should keyvault be in sdk/security or sdk/keyvault ? #2126

antkmsft opened this issue Feb 12, 2025 · 1 comment
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.

Comments

@antkmsft
Copy link
Member

antkmsft commented Feb 12, 2025 •
edited
Loading

In Go, keyvault is located in sdk/security.

In Rust and C++, it is located in sdk/keyvault.

I am going to open an issue for all 3 repos, if we want some consistency.

See also #2125 (same question about messaging/eventhubs)
@github-project-automation github-project-automation bot moved this to Untriaged in Azure SDK Rust Feb 12, 2025
@antkmsft antkmsft mentioned this issue Feb 12, 2025
Closed
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 12, 2025
This was referenced Feb 12, 2025
Open
Closed
@LarryOsterman
Copy link
Member

The Go SDK is unique among all the Azure SDKs because Go has a directory hierarchy based "namespace" construct for packages. That means that the layout of the Go SDK is different from all the other Azure SDKs.

We should follow the layout of all the non-Go Azure SDKs.

@LarryOsterman LarryOsterman closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Azure SDK Rust Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Projects
Azure SDK Rust
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LarryOsterman @antkmsft