Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt, update test on MongoCluster #41908

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

v-hongli1
Copy link
Contributor

@v-hongli1 v-hongli1 commented Sep 18, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Sep 18, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@Azure Azure deleted a comment from azure-pipelines bot Sep 18, 2024
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No client secret allowed.

@Azure Azure deleted a comment from azure-pipelines bot Sep 19, 2024
@Azure Azure deleted a comment from azure-pipelines bot Sep 19, 2024
@Azure Azure deleted a comment from azure-pipelines bot Sep 19, 2024
@v-hongli1
Copy link
Contributor Author

/azp run prepare-pipelines

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@XiaofeiCao
Copy link
Contributor

I'm not seeing mgmt test pipeline being created.

@v-hongli1
Copy link
Contributor Author

v-hongli1 commented Sep 19, 2024

@XiaofeiCao

I'm not seeing mgmt test pipeline being created.

I also find it a bit strange. Analyzing from the execution log of prepare-pipelines, the code used when reconfiguring the pipeline is the main branch of Azure/azure-sdk-for-java, and the changes in this PR have not been merged. Do you have any good ideas ?
The log of prepare-pipelines as follow as:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4146613&view=results

@XiaofeiCao
Copy link
Contributor

I'm not sure, But I believe we should fix it before merging the PR. Maybe there's a bug in the script.
Let's wait for Weidong's comments first.

@Azure Azure deleted a comment from azure-pipelines bot Sep 20, 2024
@Azure Azure deleted a comment from azure-pipelines bot Sep 20, 2024
@weshaggard
Copy link
Member

/azp run prepare-pipelines

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-hongli1
Copy link
Contributor Author

/azp run java - mongocluster - mgmt - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-hongli1
Copy link
Contributor Author

@weidongxu-microsoft @XiaofeiCao
The mgmt test pipeline has been created by prepare-pipelines , but I cannot confirm whether the live test case added in the PR has been executed. Can you help me confirm this ?

@weidongxu-microsoft
Copy link
Member

Looks good on tests column
image

Though I also didn't see any log output in pipeline.

@v-hongli1
Copy link
Contributor Author

/azp run java - mongocluster - mgmt - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-hongli1 v-hongli1 enabled auto-merge (squash) September 23, 2024 07:48
@XiaofeiCao XiaofeiCao merged commit 541f3c4 into Azure:main Sep 23, 2024
23 checks passed
mssfang pushed a commit to mssfang/azure-sdk-for-java that referenced this pull request Oct 21, 2024
* mgmt, update test on MongoCluster

* remove output AZURE_CLIENT_SECRET.

* Add `UseFederatedAuth: true` to `tests.mgmt.yml`

* Update live test case name to `testCreateMongoCluster`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants