Skip to content

Conversation

azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Oct 16, 2025

Configurations: 'specification/vmware/resource-manager/Microsoft.AVS/AVS/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: '76b0b83db710d3e15c4cba3cc96b9cb57f590eee' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5462157 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=062ad53b-32aa-f011-bbd3-6045bd05dd14 Submitted by: [email protected]

Release Plan Details

…AVS/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: '76b0b83db710d3e15c4cba3cc96b9cb57f590eee' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5462157 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Oct 16, 2025
Copy link

github-actions bot commented Oct 16, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure/arm-avs

@kazrael2119 kazrael2119 added Self-Service Release PR for self-service release and removed Self-Service Release PR for self-service release labels Oct 16, 2025
@cataggar
Copy link
Member

1 test failure on operation list test:

@azure/arm-avs:test:node: [vitest]  FAIL  test/public/avs_examples.spec.ts > avs test > operation list test
@azure/arm-avs:test:node: [vitest] RecorderError: Unable to find a record for the request GET https://sanitized.azure.com/providers/Microsoft.AVS/operations?api-version=2025-09-01
@azure/arm-avs:test:node: [vitest] Uri doesn't match:
@azure/arm-avs:test:node: [vitest]     request <[https://Sanitized.azure.com/providers/Microsoft.AVS/operations?api-version=2025-09-01>](https://sanitized.azure.com/providers/Microsoft.AVS/operations?api-version=2025-09-01%3E)
@azure/arm-avs:test:node: [vitest]     record  <[https://Sanitized.azure.com/providers/Microsoft.AVS/operations?api-version=2024-09-01>](https://sanitized.azure.com/providers/Microsoft.AVS/operations?api-version=2024-09-01%3E)
@azure/arm-avs:test:node: [vitest] Header differences:
@azure/arm-avs:test:node: [vitest] Body differences:
@azure/arm-avs:test:node: [vitest] 
@azure/arm-avs:test:node: [vitest]  ❯ Recorder.handleTestProxyErrors ../../test-utils/recorder/src/recorder.ts:519:13
@azure/arm-avs:test:node: [vitest]  ❯ Object.sendRequest ../../test-utils/recorder/src/recorder.ts:545:14
@azure/arm-avs:test:node: [vitest]  ❯ Object.sendRequest ../../core/ts-http-runtime/src/policies/redirectPolicy.ts:39:24
@azure/arm-avs:test:node: [vitest]  ❯ Object.sendRequest ../../core/ts-http-runtime/src/policies/retryPolicy.ts:57:22
@azure/arm-avs:test:node: [vitest]  ❯ trySendRequest ../../core/core-rest-pipeline/src/policies/bearerTokenAuthenticationPolicy.ts:120:13
@azure/arm-avs:test:node: [vitest]  ❯ Object.sendRequest ../../core/core-rest-pipeline/src/policies/bearerTokenAuthenticationPolicy.ts:238:27
@azure/arm-avs:test:node: [vitest]  ❯ sendRequest ../../core/ts-http-runtime/src/client/sendRequest.ts:42:22
@azure/arm-avs:test:node: [vitest]  ❯ Object.getPage src/static-helpers/pagingHelpers.ts:106:13
@azure/arm-avs:test:node: [vitest]     104|       const result =
@azure/arm-avs:test:node: [vitest]     105|         pageLink === undefined
@azure/arm-avs:test:node: [vitest]     106|           ? await getInitialResponse()
@azure/arm-avs:test:node: [vitest]        |             ^
@azure/arm-avs:test:node: [vitest]     107|           : await client.pathUnchecked(pageLink).get();
@azure/arm-avs:test:node: [vitest]     108|       checkPagingRequest(result, expectedStatuses);
@azure/arm-avs:test:node: [vitest]  ❯ getPageAsyncIterator src/static-helpers/pagingHelpers.ts:177:18

Copy link
Member

@cataggar cataggar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change log looks good.

@cataggar cataggar marked this pull request as ready for review October 16, 2025 16:58
@cataggar cataggar requested a review from qiaozha as a code owner October 16, 2025 16:58
@Copilot Copilot AI review requested due to automatic review settings October 16, 2025 16:58
@cataggar cataggar requested review from a team, MaryGao and jeremymeng as code owners October 16, 2025 16:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure VMware Solution (AVS) SDK from API version 2024-09-01 to 2025-09-01. The changes include updating API version references in sample files, documentation, dependency version updates, and adding new VCF license functionality.

  • Updates API version references from 2024-09-01 to 2025-09-01 across all sample files
  • Adds new VCF license properties to PrivateCloud creation samples
  • Updates dependency versions and adds new maintenance and license operations
  • Adds new sample files for licensing and maintenance functionality

Reviewed Changes

Copilot reviewed 299 out of 505 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/avs/arm-avs/samples/v7/typescript/src/*.ts Updates x-ms-original-file references from 2024-09-01 to 2025-09-01
sdk/avs/arm-avs/samples/v7/typescript/package.json Updates @azure/identity to 4.11.1 and adds cross-env dependency
sdk/avs/arm-avs/samples/v7/typescript/README.md Updates documentation with new sample files and 2025-09-01 API references
sdk/avs/arm-avs/samples/v7/javascript/*.js Updates x-ms-original-file references from 2024-09-01 to 2025-09-01
sdk/avs/arm-avs/samples/v7/javascript/package.json Updates @azure/identity to 4.11.1
sdk/avs/arm-avs/samples/v7/javascript/README.md Updates documentation with new sample files and 2025-09-01 API references
sdk/avs/arm-avs/samples-dev/*.ts Updates x-ms-original-file references and import organization
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

### Features Added
- Added operation group LicensesOperations
- Added operation group MaintenancesOperations
- Added operation group ServiceComponentsOperations
Copy link
Member

@cataggar cataggar Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was marked as internal in the TypeSpec. Is there a way to prevent this from showing up in the SDK?

Copy link
Member

@cataggar cataggar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd like to have ServiceComponents not included in the client.

…AVS/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'd9fea55fd43a4a37a4bbca5bfa1a0f84497f0436' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5478823 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants