[EngSys] ensure dev dependencies include our eslint plugin #36736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if a package don't lint package (i.e., "echo skipped..."), we don't include `@azure/eslint-plugin-azure-sdk` in its dev dependencies. However, this makes manually running `eslint` impossible when the directory has an `eslint.config.mjs` (likely from codegen) which imports our plugin. This PR adds `@azure/eslint-plugin-azure-sdk` back to packages.
jeremymeng
requested review from
a team,
MaryGao,
joheredi,
qiaozha and
xirzec
as code owners
github-actions
bot
added
Farmbeats
Mgmt
Copilot finished reviewing on behalf of
jeremymeng
November 24, 2025 20:30
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds @azure/eslint-plugin-azure-sdk to the devDependencies of ARM packages that have linting skipped. This ensures that ESLint can run successfully when these packages contain eslint.config.mjs files generated by codegen that import the Azure SDK ESLint plugin.
Key changes:
- Adds
@azure/eslint-plugin-azure-sdkto devDependencies withworkspace:^version specifier - Alphabetizes dependencies and npm scripts in affected packages for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a package don't lint package (i.e., "echo skipped..."), we don't
include
@azure/eslint-plugin-azure-sdkin its dev dependencies. However, thismakes manually running
eslintimpossible when the directory has aneslint.config.mjs(likely from codegen) which imports our plugin.This PR adds
@azure/eslint-plugin-azure-sdkback to packages.Fixes #36712.