[AutoPR @azure-arm-containerserviceaimanager]-generated-from-SDK Generation - JS-6627707 - #39436
Conversation
…osoft.ContainerService/aimanager/tspconfig.yaml', API Version: 2026-05-02-preview, SDK Release Type: beta, and CommitSHA: '358882ad707dcc3b0d1de9df6ba4dfba7e85da1a' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6627707 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
Azure Pipelines: Successfully started running 2 pipeline(s). 8 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Adds a new Azure Resource Manager (management-plane) client library package @azure/arm-containerserviceaimanager and wires it into the repo’s CI/ownership/configuration.
Changes:
- Register
arm-containerserviceaimanagerin ContainerService CI and CODEOWNERS. - Add the generated TypeScript client, helpers (paging/LRO/url-template), and public entrypoints for the new package.
- Add samples (TS/JS) and package scaffolding (configs, metadata, README/CHANGELOG, tests).
Reviewed changes
Copilot reviewed 150 out of 151 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/containerservice/ci.mgmt.yml | Adds the new package to mgmt CI trigger/pr paths and artifact list. |
| sdk/containerservice/arm-containerserviceaimanager/warp.config.yml | Defines build/exports/targets for the new package. |
| sdk/containerservice/arm-containerserviceaimanager/vitest.config.ts | Hooks package vitest to shared config. |
| sdk/containerservice/arm-containerserviceaimanager/vitest.browser.config.ts | Hooks browser vitest config. |
| sdk/containerservice/arm-containerserviceaimanager/tsp-location.yaml | Tracks source swagger/spec location for generation. |
| sdk/containerservice/arm-containerserviceaimanager/tsconfig.json | TS project references for builds/tests/samples. |
| sdk/containerservice/arm-containerserviceaimanager/test/snippets.spec.ts | Snippet-validation tests for README snippets. |
| sdk/containerservice/arm-containerserviceaimanager/test/public/utils/recordedClient.ts | Recorder bootstrap helper for live/recorded tests. |
| sdk/containerservice/arm-containerserviceaimanager/test/public/sampleTest.spec.ts | Placeholder public test scaffold. |
| sdk/containerservice/arm-containerserviceaimanager/src/static-helpers/urlTemplate.ts | Implements RFC 6570 URL template expansion helper. |
| sdk/containerservice/arm-containerserviceaimanager/src/static-helpers/pollingHelpers.ts | LRO poller helper for @azure/core-lro + rest client. |
| sdk/containerservice/arm-containerserviceaimanager/src/static-helpers/pagingHelpers.ts | Generic paging async-iterator helper. |
| sdk/containerservice/arm-containerserviceaimanager/src/static-helpers/cloudSettingHelpers.ts | Cloud setting → ARM endpoint resolution helper. |
| sdk/containerservice/arm-containerserviceaimanager/src/restorePollerHelpers.ts | Restore LRO pollers from serialized state. |
| sdk/containerservice/arm-containerserviceaimanager/src/models/index.ts | Re-exports generated model types and Known* enums. |
| sdk/containerservice/arm-containerserviceaimanager/src/logger.ts | Package logger initialization. |
| sdk/containerservice/arm-containerserviceaimanager/src/index.ts | Public package entrypoint exports. |
| sdk/containerservice/arm-containerserviceaimanager/src/containerServiceClient.ts | Primary client class wiring operation groups. |
| sdk/containerservice/arm-containerserviceaimanager/src/classic/operations/index.ts | Classic-layer operations group for provider operations. |
| sdk/containerservice/arm-containerserviceaimanager/src/classic/modelSources/index.ts | Classic-layer ModelSources operations group. |
| sdk/containerservice/arm-containerserviceaimanager/src/classic/modelDeployments/index.ts | Classic-layer ModelDeployments operations group. |
| sdk/containerservice/arm-containerserviceaimanager/src/classic/index.ts | Classic-layer type exports. |
| sdk/containerservice/arm-containerserviceaimanager/src/classic/aiModels/index.ts | Classic-layer AIModels operations group. |
| sdk/containerservice/arm-containerserviceaimanager/src/classic/aiManagers/index.ts | Classic-layer AIManagers operations group. |
| sdk/containerservice/arm-containerserviceaimanager/src/classic/aiManagerNamespaces/index.ts | Classic-layer AIManagerNamespaces operations group. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/operations/options.ts | REST-layer options types for operations list. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/operations/operations.ts | REST-layer send/deserialize + paging for operations list. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/operations/index.ts | REST-layer barrel exports for operations. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/modelSources/options.ts | REST-layer options for ModelSources. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/modelSources/operations.ts | REST-layer ModelSources send/deserialize + LRO/paging. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/modelSources/index.ts | REST-layer barrel exports for ModelSources. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/modelDeployments/options.ts | REST-layer options for ModelDeployments. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/modelDeployments/operations.ts | REST-layer ModelDeployments send/deserialize + LRO/paging. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/modelDeployments/index.ts | REST-layer barrel exports for ModelDeployments. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/index.ts | REST-layer barrel exports for context/client types. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/containerServiceContext.ts | REST client context creation (endpoint/scopes/UA/logging). |
| sdk/containerservice/arm-containerserviceaimanager/src/api/aiModels/options.ts | REST-layer options for AIModels. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/aiModels/operations.ts | REST-layer AIModels operations (calculateCost/get/list). |
| sdk/containerservice/arm-containerserviceaimanager/src/api/aiModels/index.ts | REST-layer barrel exports for AIModels. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/aiManagers/options.ts | REST-layer options for AIManagers. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/aiManagers/index.ts | REST-layer barrel exports for AIManagers. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/aiManagerNamespaces/options.ts | REST-layer options for AIManagerNamespaces. |
| sdk/containerservice/arm-containerserviceaimanager/src/api/aiManagerNamespaces/index.ts | REST-layer barrel exports for AIManagerNamespaces. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/tsconfig.json | TypeScript samples compilation config. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/operationsListSample.ts | TS sample: list provider operations. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/modelSourcesListSample.ts | TS sample: list model sources. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/modelSourcesGetSample.ts | TS sample: get model source. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/modelSourcesDeleteSample.ts | TS sample: delete model source (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/modelSourcesCreateOrUpdateSample.ts | TS sample: create/update model source (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/modelDeploymentsListByAIManagerNamespaceSample.ts | TS sample: list model deployments by namespace. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/modelDeploymentsGetSample.ts | TS sample: get model deployment. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/modelDeploymentsDeleteSample.ts | TS sample: delete model deployment (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/modelDeploymentsCreateOrUpdateSample.ts | TS sample: create/update model deployment (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiModelsListSample.ts | TS sample: list AI models. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiModelsGetSample.ts | TS sample: get AI model. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiModelsCalculateCostSample.ts | TS sample: calculate cost. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagersUpdateSample.ts | TS sample: update AI manager. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagersListCredentialSample.ts | TS sample: list AI manager credentials. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagersListBySubscriptionSample.ts | TS sample: list AI managers by subscription. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagersListByResourceGroupSample.ts | TS sample: list AI managers by resource group. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagersGetSample.ts | TS sample: get AI manager. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagersDeleteSample.ts | TS sample: delete AI manager (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagersCreateOrUpdateSample.ts | TS sample: create AI manager (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagerNamespacesRotateKeysSample.ts | TS sample: rotate namespace keys. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagerNamespacesListCredentialSample.ts | TS sample: list namespace credentials. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagerNamespacesListByAIManagerSample.ts | TS sample: list namespaces by manager. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagerNamespacesListAccessKeysSample.ts | TS sample: list namespace access keys. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagerNamespacesGetSample.ts | TS sample: get namespace. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagerNamespacesDeleteSample.ts | TS sample: delete namespace (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/src/aiManagerNamespacesCreateOrUpdateSample.ts | TS sample: create namespace (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/sample.env | TS sample env template. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/package.json | TS samples package manifest. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/README.md | TS samples documentation. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/sample.env | JS sample env template. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/package.json | JS samples package manifest. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/operationsListSample.js | JS sample: list provider operations. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/modelSourcesListSample.js | JS sample: list model sources. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/modelSourcesGetSample.js | JS sample: get model source. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/modelSourcesDeleteSample.js | JS sample: delete model source (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/modelSourcesCreateOrUpdateSample.js | JS sample: create/update model source (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/modelDeploymentsListByAIManagerNamespaceSample.js | JS sample: list model deployments by namespace. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/modelDeploymentsGetSample.js | JS sample: get model deployment. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/modelDeploymentsDeleteSample.js | JS sample: delete model deployment (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/modelDeploymentsCreateOrUpdateSample.js | JS sample: create/update model deployment (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiModelsListSample.js | JS sample: list AI models. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiModelsGetSample.js | JS sample: get AI model. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiModelsCalculateCostSample.js | JS sample: calculate cost. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagersUpdateSample.js | JS sample: update AI manager. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagersListCredentialSample.js | JS sample: list AI manager credentials. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagersListBySubscriptionSample.js | JS sample: list AI managers by subscription. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagersListByResourceGroupSample.js | JS sample: list AI managers by resource group. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagersGetSample.js | JS sample: get AI manager. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagersDeleteSample.js | JS sample: delete AI manager (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagersCreateOrUpdateSample.js | JS sample: create AI manager (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagerNamespacesRotateKeysSample.js | JS sample: rotate namespace keys. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagerNamespacesListCredentialSample.js | JS sample: list namespace credentials. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagerNamespacesListByAIManagerSample.js | JS sample: list namespaces by manager. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagerNamespacesListAccessKeysSample.js | JS sample: list namespace access keys. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagerNamespacesGetSample.js | JS sample: get namespace. |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagerNamespacesDeleteSample.js | JS sample: delete namespace (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/aiManagerNamespacesCreateOrUpdateSample.js | JS sample: create namespace (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/javascript/README.md | JS samples documentation. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/operationsListSample.ts | Dev sample: list provider operations. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/modelSourcesListSample.ts | Dev sample: list model sources. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/modelSourcesGetSample.ts | Dev sample: get model source. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/modelSourcesDeleteSample.ts | Dev sample: delete model source (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/modelSourcesCreateOrUpdateSample.ts | Dev sample: create/update model source (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/modelDeploymentsListByAIManagerNamespaceSample.ts | Dev sample: list model deployments by namespace. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/modelDeploymentsGetSample.ts | Dev sample: get model deployment. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/modelDeploymentsDeleteSample.ts | Dev sample: delete model deployment (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/modelDeploymentsCreateOrUpdateSample.ts | Dev sample: create/update model deployment (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiModelsListSample.ts | Dev sample: list AI models. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiModelsGetSample.ts | Dev sample: get AI model. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiModelsCalculateCostSample.ts | Dev sample: calculate cost. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagersUpdateSample.ts | Dev sample: update AI manager. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagersListCredentialSample.ts | Dev sample: list AI manager credentials. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagersListBySubscriptionSample.ts | Dev sample: list AI managers by subscription. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagersListByResourceGroupSample.ts | Dev sample: list AI managers by resource group. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagersGetSample.ts | Dev sample: get AI manager. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagersDeleteSample.ts | Dev sample: delete AI manager (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagersCreateOrUpdateSample.ts | Dev sample: create AI manager (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagerNamespacesRotateKeysSample.ts | Dev sample: rotate namespace keys. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagerNamespacesListCredentialSample.ts | Dev sample: list namespace credentials. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagerNamespacesListByAIManagerSample.ts | Dev sample: list namespaces by manager. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagerNamespacesListAccessKeysSample.ts | Dev sample: list namespace access keys. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagerNamespacesGetSample.ts | Dev sample: get namespace. |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagerNamespacesDeleteSample.ts | Dev sample: delete namespace (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/samples-dev/aiManagerNamespacesCreateOrUpdateSample.ts | Dev sample: create namespace (LRO). |
| sdk/containerservice/arm-containerserviceaimanager/sample.env | Package-level env template. |
| sdk/containerservice/arm-containerserviceaimanager/package.json | New package manifest (exports/build/test scripts/deps). |
| sdk/containerservice/arm-containerserviceaimanager/metadata.json | Generation metadata + cross-language mappings. |
| sdk/containerservice/arm-containerserviceaimanager/eslint.config.mjs | Package ESLint configuration. |
| sdk/containerservice/arm-containerserviceaimanager/config/tsconfig.test.node.json | Node test TS config. |
| sdk/containerservice/arm-containerserviceaimanager/config/tsconfig.test.browser.json | Browser test TS config. |
| sdk/containerservice/arm-containerserviceaimanager/config/tsconfig.src.esm.json | ESM build TS config. |
| sdk/containerservice/arm-containerserviceaimanager/config/tsconfig.src.cjs.json | CJS build TS config. |
| sdk/containerservice/arm-containerserviceaimanager/config/tsconfig.src.browser.json | Browser build TS config. |
| sdk/containerservice/arm-containerserviceaimanager/config/tsconfig.snippets.json | Snippets TS config. |
| sdk/containerservice/arm-containerserviceaimanager/config/tsconfig.samples.json | Samples TS config. |
| sdk/containerservice/arm-containerserviceaimanager/config/tsconfig.lint.json | Lint TS config. |
| sdk/containerservice/arm-containerserviceaimanager/api-extractor.json | API extractor config for public API review. |
| sdk/containerservice/arm-containerserviceaimanager/README.md | Package README with auth/logging/snippets. |
| sdk/containerservice/arm-containerserviceaimanager/LICENSE | Package license file. |
| sdk/containerservice/arm-containerserviceaimanager/CHANGELOG.md | Initial changelog for beta. |
| eng/ignore-links.txt | Adds docs/npm links to link checker ignore list. |
| .github/CODEOWNERS | Adds ownership for new package path. |
Comments suppressed due to low confidence (7)
sdk/containerservice/arm-containerserviceaimanager/src/static-helpers/urlTemplate.ts:1
- The character class
/[.~-]/creates an unintended ASCII range from.to~(because-is treated as a range operator), so this will decode many reserved characters. Escape or reposition the hyphen (e.g.,[-.~_]) and consider expanding the predicate to match RFC3986 unreserved characters (ALPHA / DIGIT / \"-\" / \".\" / \"_\" / \"~\").
sdk/containerservice/arm-containerserviceaimanager/src/static-helpers/pagingHelpers.ts:1 - This uses
createRestError(message, response)but elsewhere in this package the helper is called ascreateRestError(response)(and then details are attached). If@azure-rest/core-clientdoesn't support the two-argument form, this will be a compile/runtime error. Align with the supported API (e.g., create the error fromresponseand then overrideerror.message, or thrownew RestError(...)with the response attached).
sdk/containerservice/arm-containerserviceaimanager/src/static-helpers/urlTemplate.ts:1 - The empty-string handling appears inverted: when
ifEmptyis non-empty (e.g., for?/&operators) the code should append it, but it currently appends only whenifEmptyis falsy. This will produce incorrect expansions for empty values in named expressions. Update the condition soifEmptyis appended when it is present.
sdk/containerservice/arm-containerserviceaimanager/src/static-helpers/pollingHelpers.ts:1 - The same
addApiVersionToUrlhelper is duplicated in bothpollingHelpers.tsandpagingHelpers.ts. Consider extracting it into a single shared utility to avoid divergence/bugfix duplication (especially around URL edge cases like existing query strings, fragments, and already-encoded URLs).
sdk/containerservice/arm-containerserviceaimanager/tsp-location.yaml:1 additionalDirectories:is present but has no value, which can be interpreted asnulland may break tooling expecting an array/list. If there are no additional directories, prefer removing the key entirely or setting it explicitly to an empty list (e.g.,additionalDirectories: []).
sdk/containerservice/arm-containerserviceaimanager/samples/v1-beta/typescript/package.json:1- Using floating versions like
latestin committed sample package manifests can make builds non-reproducible and increases supply-chain risk (a new major release can break or change behavior unexpectedly). Prefer pinning to a known-good major/minor range (e.g.,^x.y.z) consistent with repo policies.
sdk/containerservice/arm-containerserviceaimanager/src/static-helpers/pagingHelpers.ts:1 - The new paging helper introduces non-trivial behavior (nextLink parsing/type validation,
nextLinkMethodGET vs POST, api-version injection, and error paths). Add unit tests covering: (1) nextLink present/absent/null, (2) non-string nextLink throws, (3) GET vs POST, and (4) api-version already present vs appended.
Next Steps to Merge✅ All CI checks have passed — this PR is ready for review! The SDK engineer will review this PR shortly. Once it's approved, you can go ahead and merge it. To make things easier, feel free to enable auto-merge so it gets auto merged right after approval. For more details, see the [management SDK release process]((eng.ms/redacted) |
|
hold on as Azure/azure-sdk-for-python#48300 (comment) |
There was a problem hiding this comment.
No API design or tooling issues found in this PR. The new @azure/arm-containerserviceaimanager package (1.0.0-beta.1) introduces a clean first beta release with a proper CHANGELOG, correct KnownVersions enum entries (V20260402Preview, V20260502Preview), consistent API surface following modular SDK patterns, and valid metadata.json (api-version 2026-05-02-preview). All public symbols are appropriately tagged @public.
📊 Structured Report
{"agent":"mgmt-reviewer","pr":39436,"summary":"clean","findings":[]}⚡ Benchmarked by Management Release Assistant
Configurations: 'specification/containerservice/resource-manager/Microsoft.ContainerService/aimanager/tspconfig.yaml', API Version: 2026-05-02-preview, SDK Release Type: beta, and CommitSHA: '358882ad707dcc3b0d1de9df6ba4dfba7e85da1a' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6627707 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=35566 Submitted by: weisara@microsoft.com