Improve code coverage for depployment entity #39403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdhotems
requested review from
paulshealy1,
achauhan-scc,
kingernupur and
jayesh-tanna
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
This reverts commit 3aee0c6.
jayesh-tanna
reviewed
Feb 4, 2025
sdk/ml/azure-ai-ml/tests/test_configs/deployments/batch/batch_deployment_full_rest.json
Outdated
Show resolved
Hide resolved
achauhan-scc
approved these changes
Feb 4, 2025
l0lawrence
pushed a commit
to l0lawrence/azure-sdk-for-python
that referenced
this pull request
Feb 19, 2025
* add unit tests for OnlineDeployment rest to entity conversion * add unit tests for onlinedeployment entity _get_arm_resource_and_params * move unit tests online_deployment_from_rest_object to right class * add unit tests for get arm resource for kubenets deployment * add unit tests for onlinedeployment entity set scale settings * add unit tests for to_dict method * code formatting * change comment to run tests * Update assets.json * Revert "Update assets.json" This reverts commit 3aee0c6. * disable failing tests * disable failing tests * enable failing tests and update recordings * add unit tests for OnlineDeployment merge * fix unit test * add unit tests for to_rest_object * update unit tests for resource settings * update unit tests for resource settings * add unit tests for online deployment settings * add unit tests for batch deployment * code formatting * add unit tests batch endpoint deployment * add unit tests for batch deployment * add unit tests for batch job * add unit tests for batch job * add unit tests for model deployment class * code formatting * remove unwanted tests * add unit tests for pipeline_component_batch_deployment.py * clean json rest response file * clean json rest response file
cRui861
pushed a commit
that referenced
this pull request
Feb 27, 2025
* add unit tests for OnlineDeployment rest to entity conversion * add unit tests for onlinedeployment entity _get_arm_resource_and_params * move unit tests online_deployment_from_rest_object to right class * add unit tests for get arm resource for kubenets deployment * add unit tests for onlinedeployment entity set scale settings * add unit tests for to_dict method * code formatting * change comment to run tests * Update assets.json * Revert "Update assets.json" This reverts commit 3aee0c6. * disable failing tests * disable failing tests * enable failing tests and update recordings * add unit tests for OnlineDeployment merge * fix unit test * add unit tests for to_rest_object * update unit tests for resource settings * update unit tests for resource settings * add unit tests for online deployment settings * add unit tests for batch deployment * code formatting * add unit tests batch endpoint deployment * add unit tests for batch deployment * add unit tests for batch job * add unit tests for batch job * add unit tests for model deployment class * code formatting * remove unwanted tests * add unit tests for pipeline_component_batch_deployment.py * clean json rest response file * clean json rest response file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for online_deployment_entity
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines