[Projects] Draft #39960
Open
[Projects] Draft #39960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR establishes the initial draft of the Azure Projects library for Python with scaffolding for resource definitions, bicep expressions, and deployment provisioning.
- New README, changelog, and version file.
- Comprehensive additions in bicep expression classes and utilities.
- Provisioning and parameter handling functionality for project deployment.
Reviewed Changes
| File | Description |
|---|---|
| sdk/projects/azure-projects/README.md | Added introductory documentation for the library. |
| sdk/projects/azure-projects/azure/projects/resources/_extension/roles/types.py | Introduced type definitions for role assignments. |
| sdk/projects/azure-projects/azure/projects/_version.py | Version file establishing the initial version. |
| sdk/projects/azure-projects/azure/projects/_bicep/expressions.py | Added classes for bicep expressions, parameters, variables, and outputs. |
| sdk/projects/azure-projects/azure/projects/_setting.py | New module for prioritized setting management. |
| sdk/projects/azure-projects/azure/projects/resources/_identifiers.py | Added resource identifier constants and resource mapper. |
| sdk/projects/azure-projects/azure/projects/_bicep/utils.py | Introduced utility functions for bicep serialization and name generation. |
| sdk/projects/azure-projects/CHANGELOG.md | Initial changelog for the package release. |
| sdk/projects/azure-projects/azure/projects/resources/_extension/roles/init.py | Added a role assignment resource with built-in role definitions. |
| sdk/projects/azure-projects/azure/projects/_parameters.py | Added parameters and global parameters definition for deployments. |
| sdk/projects/azure-projects/azure/projects/_provision.py | Added provisioning logic to initialize and deploy Azure projects. |
| Others | Additional resource definitions, AI services resource, and module initialization files. |
Copilot reviewed 269 out of 269 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
sdk/projects/azure-projects/azure/projects/resources/ai/init.py:241
- Using str.format() directly on a Parameter object may lead to a runtime error if the Parameter does not override format. Consider extracting the underlying string value before formatting.
'name': GLOBAL_PARAMS['defaultName'].format("{}-aiservices"),
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.