[Cosmos] add backwards compatibility tests for irrelevant kwargs #40150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds backwards compatibility tests to ensure that unused kwargs such as session_token and etag/match_condition do not affect the behavior of Cosmos DB methods.
- Added asynchronous test cases for session_token and etag/match_condition compatibility.
- Added synchronous test cases to mirror async tests for validating compatibility across Database, Container, and Item operations.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos/tests/test_backwards_compatibility_async.py | New async tests validating backwards compatibility for irrelevant kwargs. |
| sdk/cosmos/azure-cosmos/tests/test_backwards_compatibility.py | Added sync tests to check that session_token and etag/match_condition parameters do not break existing behavior. |
sdk/cosmos/azure-cosmos/tests/test_backwards_compatibility_async.py
Outdated
Show resolved
Hide resolved
|
API change check API changes are not detected in this pull request. |
annatisch
approved these changes
Mar 19, 2025
…nc.py Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR 40008 we are removing several options that are available in methods where they don't make sense. As part of that work, we are also rolling out these backwards compatibility tests to ensure that they work both before and after removing these from the method signatures, ensuring this has no breaking behavior on the affected methods.