Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution comments #110

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Contribution comments #110

merged 1 commit into from
Oct 7, 2022

Conversation

JJHWAN
Copy link
Contributor

@JJHWAN JJHWAN commented Oct 6, 2022

#109

Type hint에 대한 Contribution.md 를 만들었습니다.

Copy link
Contributor

@jeesang7 jeesang7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1e1fa2a

위 커밋 참고하셔서, _data/sidebars/general_sidebar.yml 에도 추가 부탁드려요.
혹시, 추가 하는 부분이 잘 이해안되시면, 답변이나 디스코드 연락 주세요 😄

@ianychoi
Copy link
Collaborator

ianychoi commented Oct 7, 2022

Looks great! Two additional comments for @JJHWAN:

  1. Would you change a commit message: "mend" to some other?
  2. Please address as @jeesang7 mentioned

Thanks!

Add how to start type-hint contribution  and related PRs

Which seems best issues to start with.

mend
@JJHWAN JJHWAN force-pushed the contribution-comments branch from 9ab45a7 to 2f480e4 Compare October 7, 2022 11:48
@JJHWAN
Copy link
Contributor Author

JJHWAN commented Oct 7, 2022

두 분이 말씀하신 변경 모두 적용했습니다
리뷰 감사합니다 :)

@ianychoi
Copy link
Collaborator

ianychoi commented Oct 7, 2022

Thank you!

@ianychoi ianychoi merged commit 2b210f8 into Azure:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants