Repository navigation
Sync eng/common directory with azure-sdk-tools for PR 17315 - #10364
Merged
Ray Chen (raych1) merged 3 commits intoOct 21, 2026
Merged
Ray Chen (raych1) merged 3 commits into
Ray Chen (raych1) merged 3 commits into
Conversation
azure-sdk-automation
Bot
requested review from
Helen Gao (helen229)
and
a balanced review from Copilot
October 21, 2026 16:22
azure-sdk-automation
Bot
added
EngSys
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Cross-platform Azure CLI upload handling requires human confirmation of the Tools-only integration test results.
No open issues 🎉
What changed in this PR
Syncs shared evaluation tooling from azure-sdk-tools PR #17315 into eng/common.
Changes:
- Selects only timeline-matching shard artifacts for summaries and publication.
- Improves Azure CLI argument handling, JSON parsing, and safe error reporting.
- Removes Tools-only dependencies from shared tests and adds consumer-copy coverage.
| File | Description |
|---|---|
eng/common/scripts/eval/test/shard-results.test.ts |
Covers timeline-matching selection and excluded stale results. |
eng/common/scripts/eval/README.md |
Documents selection, CLI handling, and test ownership. |
eng/common/scripts/eval/publisher/test/publisher.test.ts |
Adds consumer-copy checks and updates pipeline expectations. |
eng/common/scripts/eval/publisher/Publish-EvalResults.ps1 |
Improves upload arguments, output parsing, and diagnostics. |
eng/common/scripts/eval/publisher/package.json |
Removes Tools-only PowerShell tests from the shared test command. |
eng/common/scripts/eval/publisher/CHANGELOG.md |
Records the synced improvements. |
eng/common/scripts/eval/lib/shard-results.ts |
Requires artifacts to match verified timeline attempts. |
eng/common/scripts/eval/build-eval-summary.ts |
Updates the warning for unavailable timeline evidence. |
Review effort: Balanced
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Helen Gao (helen229)
approved these changes
Oct 21, 2026
Helen Gao (helen229)
left a comment
Helen Gao (helen229)
left a comment
Member
There was a problem hiding this comment.
Approving the eng/common sync for Azure/azure-sdk-tools#17315. Reporting and upload changes match the source, and additional shared YAML changes match the source baseline.
Ray Chen (raych1)
deleted the
sync-eng-common-fix/eval-reporting-test-portability-17315
branch
October 21, 2026 18:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#17315 See eng/common workflow