Repository navigation
Sync eng/common directory with azure-sdk-tools for PR 17393 - #10381
Merged
Praveen Kuttappan (praveenkuttappan) merged 2 commits intoOct 27, 2026
Conversation
azure-sdk-automation
Bot
requested review from
Helen Gao (helen229)
and
a balanced review from Copilot
October 26, 2026 22:25
azure-sdk-automation
Bot
added
EngSys
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes preserve explicit and populated runtime values while handling missing optional values, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Syncs shared engineering files from Azure/azure-sdk-tools PR #17393 to fix SDK pull request handling during release-plan completion.
Changes:
- Uses the runtime
AutoReleaseSdkPullRequestUrlwhen no explicitSdkPullRequestis supplied. - Initializes an absent or empty runtime value for manual runs while preserving populated values.
- Documents the fix in the common engineering changelog.
| File | Description |
|---|---|
eng/common/pipelines/templates/steps/mark-release-completion.yml |
Adds runtime initialization and the SDK PR fallback. |
eng/common/CHANGELOG.md |
Documents the corrected release-completion behavior. |
Review effort: Balanced
Helen Gao (helen229)
approved these changes
Oct 27, 2026
Helen Gao (helen229)
left a comment
Helen Gao (helen229)
left a comment
Member
There was a problem hiding this comment.
Approving the exact eng/common sync from Azure/azure-sdk-tools#17393. The two changed files match the source completion template and changelog.
Praveen Kuttappan (praveenkuttappan)
merged commit Oct 27, 2026
27bcd61
into
main
17 of 18 checks passed
Praveen Kuttappan (praveenkuttappan)
deleted the
sync-eng-common-fix/shared-release-completion-sdk-pr-17393
branch
October 27, 2026 21:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#17393 See eng/common workflow