Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fix to refill non last block earlier staged with half data #1643

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vibhansa-msft
Copy link
Member

Type of Change

  • Bug fix
  • New feature
  • Code quality improvement
  • Other (describe):

Description

  • Feature / Bug Fix: (Brief description of the feature or issue being addressed)

How Has This Been Tested?

Checklist

  • The purpose of this PR is explained in this or a referenced issue.
  • Tests are included and/or updated for code changes.
  • Documentation update required.
  • Updates to module CHANGELOG.md are included.
  • License headers are included in each file.

Related Links

@@ -1598,11 +1598,31 @@ func (bc *BlockCache) commitBlocks(handle *handlemap.Handle) error {
listMap[k].committed = true
}

if restageId != "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There can be multiple occurrences in a file where the block staged had size less than the configured block size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants