-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: avm/res/cache/redis
: add support for AKV secrets export
#4138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @JeffreyCA, much appreciated 💪
Thanks for the review, do I need any other approvals? |
Now that you mention it. Actually yes - @hundredacres, could you give it a look? From where I'm standing it looks good :) Your review & approval would be much appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Great work on add this feature to the Redis Cache resource. I was wondering if the Connection String could have the same format as what you would find in the 'Settings -> Authentication -> Access Key -> Primary connection string (StackExchange.Redis) & Secondary connection string (StackExchange.Redis)' This format looks like this; |
Good point - unlike most Redis clients, the StackExchange.Redis client (for .NET) uses its own connection string format and doesn't support the @AlexanderSehr @hundredacres I was thinking maybe we could add another pair of exportable secrets, something like |
Sounds good to me. Happy to take a PR, or I can whip something up tomorrow
|
Sure, I opened #4343 |
Description
Closes #4137
Add support for AKV secrets export by introducing a new
secretsExportConfiguration
input param as per https://azure.github.io/Azure-Verified-Modules/specs/bcp/res/interfaces/#secrets-export.In addition to the primary and secondary access key, I also added support for connection strings in the form
rediss://...
, which is supported by most Redis clients:secretsExportConfiguration.primaryAccessKeyName
secretsExportConfiguration.primaryConnectionStringName
rediss://:<primaryaccesskey>@<hostname>:6380
secretsExportConfiguration.secondaryAccessKeyName
secretsExportConfiguration.secondaryConnectionStringName
rediss://:<secondaryaccesskey>@<hostname>:6380
Usage example:
Pipeline Reference
Ran the
kv-secrets
E2E test locally and passed:Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.