Fix all identity certs to create P-256 / RSA-2048 key pairs. #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonwang0
approved these changes
Aug 17, 2022
Contributor
gordonwang0
left a comment
gordonwang0
left a comment
There was a problem hiding this comment.
Mariner builds failing are probably due to a keychain update in mariner. Damon's team is taking a look.
onalante-msft
approved these changes
Aug 17, 2022
Member
Author
|
In shiproom we decided to do this after the next release branch is branched, and to implement a configuration option for this to reduce the chance of regression from switching from RSA to EC certs. So I've marked this is Draft for now. |
|
I was wondering if there is an ETA for this PR to merge into main branch as I'm waiting for the fix of EST ID and Device ID certificates default to using different key types #403. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #403