Lab Migration #1002
Draft
Lab Migration #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSAL Java version of the work done in AzureAD/microsoft-authentication-library-for-dotnet#5558, and this is currently just a first-draft proof of concept to allow easier ad-hoc reviews while we finish the migration.
We are migrating from getting test config from the ID Labs API to a more Key Vault-based approach. This work was recently completed in MSAL .NET, and this PR makes similar changes in Java.
We used used Copilot to translate what was done in .NET and create equivalent behavior in Java. The result was then adjusted to fix syntax errors and config that got lost in translation, and a new
labapi2package was made to contain this new test infrastructure.labapi2is a temporary package to keep the new style completely separate so that we solve issues in a more focused way and progressively migrate all the tests.Currently, two test classes have been converted to demonstrate the new style with both public and confidential clients:
ClientCredentialsIT: Fully working, except for a CIAM test was commented out due to not yet having that user query set upUsernamePasswordIT: Fully working in the pipeline, but locally there are unexpected 504/gateway timeout issues in Arlington scenarios