Support ISO8601-ish format on expires_on in MI #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladjohn
reviewed
May 20, 2025
| "1/1/1970 12:0:12 PM +00:00": 43212, | ||
| "1/16/2020 5:24:12 AM +00:00": 1579152252, # Derived from https://github.com/Azure/azure-sdk-for-python/blob/azure-identity_1.21.0/sdk/identity/azure-identity/azure/identity/_credentials/azure_ml.py#L51 | ||
| }.items(): | ||
| self.assertEqual(_parse_expires_on(input), epoch, f'Should parse "{input}" to {epoch}') |
There was a problem hiding this comment.
would be good to have these as well.
"2025-01-01T00:00:00Z": 1735689600, (Z/Zulu Suffix)
"2025-01-01T00:00:00+00:00": 1735689600, (No fractional seconds)
gladjohn
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #760 by supporting
expires_onwith format2024-10-18T19:51:37.0000000+00:00observed in this report, plus extra formats implemented in Azure SDK for Python.