[서유정_BackEnd] 2주차 과제 제출합니다. #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHkimgit
reviewed
Mar 25, 2025
DHkimgit
left a comment
DHkimgit
left a comment
There was a problem hiding this comment.
과제하느라 수고하셨습니다. 깔끔하고 간결한 코드라 이해하기 편했어요! 다음번에는 커밋 하실 때 기능 단위로 해주시면 좋을 것 같아요. 깃허브 커밋 메시지 컨벤션 키워드를 찾아보세요!
Comment on lines
+22
to
+24
| public String getPositionToString(){ | ||
| return "-".repeat(position); | ||
| } |
Comment on lines
+16
to
+20
| public void move(){ | ||
| if (pickNumberInRange(0, 9) >= 4) { | ||
| position += 1; | ||
| } | ||
| } |
Comment on lines
+9
to
+14
| public Car(String name){ | ||
| if (name.length() > 5) { | ||
| throw new IllegalArgumentException("오류: 문자열은 최대 5글자까지만 입력할 수 있습니다."); | ||
| } | ||
| this.name = name; | ||
| } |
There was a problem hiding this comment.
Car의 생성자가 검증의 책임을 갖도록 해주셨네요. 이 부분을 private 메서드로 분리하는건 어떨까요?
Comment on lines
+4
to
+8
|
|
||
| public class Car { | ||
| private String name; | ||
| private int position = 0; | ||
|
|
Comment on lines
+22
to
+28
| for (int i = 0; i < count; i++) { | ||
| for (Car car: cars){ | ||
| car.move(); | ||
| System.out.println(car.getName() + " : " + car.getPositionToString()); | ||
| } | ||
| System.out.println(); | ||
| } |
There was a problem hiding this comment.
함수를 사용해 코드를 기능 단위로 분리할 수 있습니다. 분리된 함수에 역할이 명확히 드러나도록 이름을 잘 지어 놓으면 함수 이름만 읽어도 어떤 작업을 하는 코드인지 알 수 있고, 전체적인 흐름 파악도 쉬워져요.
| public static void main(String[] args) { | ||
| // TODO: 프로그램 구현 | ||
| System.out.println("경주할 자동차 이름을 입력하세요. (이름은 쉼표(,) 기준으로 구분)"); | ||
| String[] names = readLine().split(","); |
There was a problem hiding this comment.
join, repeat, split 등 자바에서 제공하는 api를 적극적으로 사용해 주셨네요!
dradnats1012
reviewed
Apr 4, 2025
dradnats1012
left a comment
dradnats1012
left a comment
There was a problem hiding this comment.
고생하셨습니다!
기능별 메서드 분리만 좀 더 해주면 가독성이 좀 더 좋아질 것 같아요~!
Comment on lines
+11
to
+15
| for (Car cars : winners) { | ||
| if (cars.getPosition() > winnerPosition) { | ||
| winnerPosition = cars.getPosition(); | ||
| } | ||
| } |
There was a problem hiding this comment.
이런것들도 따로 메서드로 분리할 수 있을 것 같아요!
ex) private int findWinnerPosition(), private int findMaxPosition()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1주차 과제 제출합니다.