-
Notifications
You must be signed in to change notification settings - Fork 55
[임현희_BackEnd] 1주차 과제 제출합니다. #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bajirakhyeonhee
wants to merge
4
commits into
BCSDLab-Edu:main
Choose a base branch
from
bajirakhyeonhee:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,29 @@ | ||
| package racingcar; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Arrays; | ||
| import java.util.List; | ||
| import static camp.nextstep.edu.missionutils.Console.readLine; | ||
|
|
||
| public class Application { | ||
| public static void main(String[] args) { | ||
| // TODO: 프로그램 구현 | ||
| ArrayList<Car> cars = new ArrayList<>(); | ||
| System.out.println("경주할 자동차 이름을 입력하세요."); | ||
| String name = readLine(); | ||
|
|
||
| // 피드백: 배열 → List<String>으로 바꿈 | ||
| List<String> nameList = Arrays.asList(name.split(",")); | ||
|
|
||
| for (String n : nameList) { // 피드백: 배열 → List<String>으로 바꿈 | ||
| Car car = new Car(n); | ||
| cars.add(car); | ||
| } | ||
|
|
||
| System.out.println("시도할 회수는 몇회인가요?"); | ||
| int count = Integer.parseInt(readLine()); | ||
|
|
||
| Racing race = new Racing(); | ||
| race.startRace(cars, count); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package racingcar; | ||
| import camp.nextstep.edu.missionutils.Randoms; | ||
|
|
||
| public class Car { | ||
| private static final int MOVE_THRESHOLD = 4; // 피드백: 4를 의미있는 상수로 | ||
| protected String name; | ||
| private String distance; | ||
|
|
||
| public Car(String Name) { | ||
| if (Name == null || Name.length() > 5) | ||
| throw new IllegalArgumentException(); | ||
|
Comment on lines
+10
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 검증하는 로직은 메서드로 따로 빼도 좋을 것 같아요 :) |
||
| this.name = Name; | ||
| this.distance = ""; | ||
| } | ||
|
|
||
| public void move() { // 피드백: 접근제어자 명시 (default → public) | ||
| int num = Randoms.pickNumberInRange(0, 9); | ||
| if (num >= MOVE_THRESHOLD) { | ||
| this.distance += "-"; | ||
| } | ||
| } | ||
|
|
||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| public String getDistance() { | ||
| return distance; | ||
| } | ||
|
|
||
| public int getDistanceLength() { | ||
| return distance.length(); | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package racingcar; | ||
|
|
||
| import java.util.ArrayList; | ||
|
|
||
| public class Racing { | ||
| public void startRace(ArrayList<Car> cars, Integer count) { | ||
| for (int i = 0; i < count; i++) { | ||
| for (Car c : cars) { | ||
| c.move(); | ||
| System.out.println(c.getName() + " : " + c.getDistance()); | ||
| } | ||
| System.out.println(); | ||
| } | ||
|
|
||
| int max = 0; | ||
| for (Car c : cars) { | ||
| if (c.getDistanceLength() > max) { | ||
| max = c.getDistanceLength(); | ||
| } | ||
| } | ||
|
|
||
| ArrayList<String> names = new ArrayList<>(); | ||
| for (Car c : cars) { | ||
| if (c.getDistanceLength() == max) { | ||
| names.add(c.getName()); | ||
| } | ||
| } | ||
|
|
||
| System.out.println("최종 우승자 : " + String.join(",", names)); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
보통 이렇게 선언해서 사용합니다!
저번주 강의 보시고 다형성에 대해 공부해보면 좋을 것 같아요 :)