-
Notifications
You must be signed in to change notification settings - Fork 55
[황명하_BackEnd] 2주차 과제 제출합니다 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
krSeonghyeon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2주차 과제 고생하셨습니다.
다음부터는 기간 내에 제출 부탁드려요
|
|
||
| public class Application { | ||
| public static void main(String[] args) { | ||
| Scanner sc = new Scanner(System.in); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기서는 굳이 scanner가 필요하지 않을 것 같아요
| printWinners(winners); | ||
| } | ||
|
|
||
| private static List<Car> getCars(Scanner sc) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
메소드를 분리해주셨네요 좋습니다
| { | ||
| winCars.add(car.getName()); | ||
| List<String> winners = new ArrayList<>(); | ||
| for (Car car : cars) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좀 더 함수들을 세분화할 수 있을 것 같아요
| { | ||
| // TODO: 프로그램 구현 | ||
|
|
||
| public class Application { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
클래스가 여러 책임을 가지고 있어서 더 분리할 수 있을 것 같아요
No description provided.