-
Notifications
You must be signed in to change notification settings - Fork 55
[엄성현_BackEnd] 2주차 과제 제출합니다. #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
asa9874
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2주차 과제 고생하셨습니다.👍
몇가지 코맨트 남겨뒀습니다.
| racingGame.start(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EOF 에 대해 알아보시면 좋을거같아요
| private int position=0; | ||
| public Car(String name){this.name = name;} | ||
|
|
||
| public void move(int number){if(number>=4){position++;}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
매직넘버에 대해서도 한번 알아보시면 좋을거같아요.
| int maxPosition = cars.stream() | ||
| .mapToInt(Car::getPosition) | ||
| .max() | ||
| .orElse(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stream 활용 좋아요 👍
제가 1주차 때 JAVA 실력이 부족해서 과제를 제출하지 않았지만 다시 공부해보며 과제를 완성시켰습니다.
다만 아쉬운 점으로는 제가 커밋에 익숙하지 않아 선배님들이 원하시는 방향인 코드를 적고 커밋하는 그런 방식으로 하질 않은 게 아쉬웠지만 이번에 과제를 하면서 어떤 식으로 해야 할 지 갈피를 잡았다고 생각해서 앞으로 더 잘 하도록 하겠습니다.