Skip to content

Conversation

@truhacevkir
Copy link
Contributor

Adding implemented search params to openapi schema for /resources

@truhacevkir truhacevkir requested a review from brinxmat January 27, 2026 08:50
@github-actions
Copy link

github-actions bot commented Jan 27, 2026

Test Results

   46 files  ±0     46 suites  ±0   1m 43s ⏱️ -17s
1 055 tests ±0  1 052 ✅ ±0  3 💤 ±0  0 ❌ ±0 
1 138 runs  ±0  1 135 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 7574466. ± Comparison against base commit 3297b45.

This pull request removes 5 and adds 4 tests. Note that renamed tests count towards both.

no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=mn24VlCslD2rUSRSibL, documentIdentifier=null], resource={"CcXngOy6oZoJ5gc5s":{"RXJVhC8msQaHo83ZYHz":"GId3EE7AHAVsP","7SUEsKGEyCRE":"gpyPhvLactboXP0l","rO9RSvgXR7eCx8qD7U":"TpRg06JzB5hWbq","T0bQdDSWnk6brj7":"vTcs5e3RG7TVR7o5Cpc","YB7OikxMnSG":"8R5m8cgStza59"},"Iqt1q9WEjo":{"JK3fMiPfgD":"Qq9JD64aooAWZz","lk24p50AdvfVlxSxhV":"tBWw4g34sllkHpLp","rWdZ01iOS6lk67":"riToz5NvwRetpDTSQ","tFYJtt0If0EC":"yN55TgGAiJGiMUAR","zHRD0EmAS5V1Mzz":"aF88EtSBJ…
no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=null, documentIdentifier=019bff26bc70-1b97778f-407c-4190-a577-e7afec580f37], resource={"EmplGdRxDt9PX5OQio":{"MNoBoI5725":"z9hgXfbabmzM","eveHdQW6GjCY4Chqytz":"EY71FHFvzbljG70f1","1TMIu7X2QyysZZ9YEn":"fEcRbhBKPo","cTJrl4Ww2h":"Md3pxcptB99RdQyEkFz","9iYhMQfNzoD":"dsOy7Z7n5MnNV"},"yfO6aI5P4d":{"Qj6iGgtD5izbnyOy":"pYOeTCuRrf5x6tU0Mm","5lUg51qAEDgFfCWr5":"hRNlSRKDl2r7","7JHzK50fgTIPvxf7":"7BdhZleN28","jhoIbEVzUgvI":"GFjFsRxrB65i3G6","LM7K47dC…
no.unit.nva.search.resource.ResourceClientAllScientificValuesTest ‑ [1] { "onlineIssn": "1903-6523" }
no.unit.nva.search.resource.ResourceClientAllScientificValuesTest ‑ [2] { "printIssn": "1903-6523" }
no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=GO1LqB4Iqtb, documentIdentifier=null], resource={"jim3EIK1N0atn":{"qbW8hitjHwGtZPCdRk":"xQW5xZMcoJwJe","q9RCo4jq0wAPpxIRNK":"3JtRalse9Ii9","XYb3VCAj0ii04lNIOz":"gOds9mYwMu27HC2auKL","FEXVOOK9hFwf":"2jSyZ50RNMBT","Tre3mEOfOgVnp8Js":"JzUBYvrHYjEkFOw"},"2qBFFlKQv8UpXh6VVw":{"bS8vK0XqSZnd95KA":"q6uXUw9ORYvKS2","JRoyWRURaz615bfI":"L0Fxc7V5RJC46","LKIjkVBR5MOm":"zpW88XYWBOJJ","Oqu6NpmAPGGHctiB":"1xSO4AbKbCzQe","2OzYyjTM8dTjBaT":"hubKntEBQu"},"L…
no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=null, documentIdentifier=019bff44f68a-f7f7187d-69d5-4893-8dd8-0ca1b38311b5], resource={"EI8RzDcWpInxxk":{"J9LPCPJ6LoL7QwNjgX":"wOZA2NT60uaoDbRC9","uc2YFPjmzoVBsQYRsak":"t8VP2XYx6JX4BEzDRE","8EKIA2RF812xMb3il":"zVmBtJWBK41","fvvjY1qTg6D":"QirYPRJiRRe3","f7xiB3fC0VHZkWl":"zeDW0mjs1NkPB4PRf"},"af8T6BgRi2r":{"c65VyruN6X66RMxY":"FEAVBNyjzZsITz","84qyMRICHwcH":"tmaJjiWVmN6LuW","QkncvaVYEEeWD":"rSDRRIu3hunV76","JdwpTTLwHAS":"zQRnrW0VvE9XnT","g4v…
no.unit.nva.search.resource.ResourceClientAllScientificValuesTest ‑ [1] { "onlineIssn": "1903-6523" }

no.unit.nva.search.resource.ResourceClientAllScientificValuesTest ‑ [2] { "printIssn": "1903-6523" }

♻️ This comment has been updated with latest results.

@truhacevkir truhacevkir merged commit 4dfff4b into main Jan 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants