Skip to content

Conversation

@truhacevkir
Copy link
Contributor

Updating params:
EXCLUDE_PARENT_TYPE
EXCLUDE_SCIENTIFIC_VALUE_SERIES
EXCLUDE_SCIENTIFIC_VALUE_PUBLISHER

From type NOT_ALL_OF to NOT_ANY_OF.
The difference is that one excludes documents that have ALL of provided values. Second one excludes documents that have any of provided values.

@truhacevkir truhacevkir requested a review from brinxmat January 29, 2026 07:45
@github-actions
Copy link

github-actions bot commented Jan 29, 2026

Test Results

   46 files  ±0     46 suites  ±0   1m 49s ⏱️ -11s
1 057 tests +2  1 054 ✅ +2  3 💤 ±0  0 ❌ ±0 
1 140 runs  +2  1 137 ✅ +2  3 💤 ±0  0 ❌ ±0 

Results for commit 8f218a2. ± Comparison against base commit 4dfff4b.

This pull request removes 5 and adds 6 tests. Note that renamed tests count towards both.

no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=mn24VlCslD2rUSRSibL, documentIdentifier=null], resource={"CcXngOy6oZoJ5gc5s":{"RXJVhC8msQaHo83ZYHz":"GId3EE7AHAVsP","7SUEsKGEyCRE":"gpyPhvLactboXP0l","rO9RSvgXR7eCx8qD7U":"TpRg06JzB5hWbq","T0bQdDSWnk6brj7":"vTcs5e3RG7TVR7o5Cpc","YB7OikxMnSG":"8R5m8cgStza59"},"Iqt1q9WEjo":{"JK3fMiPfgD":"Qq9JD64aooAWZz","lk24p50AdvfVlxSxhV":"tBWw4g34sllkHpLp","rWdZ01iOS6lk67":"riToz5NvwRetpDTSQ","tFYJtt0If0EC":"yN55TgGAiJGiMUAR","zHRD0EmAS5V1Mzz":"aF88EtSBJ…
no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=null, documentIdentifier=019bff26bc70-1b97778f-407c-4190-a577-e7afec580f37], resource={"EmplGdRxDt9PX5OQio":{"MNoBoI5725":"z9hgXfbabmzM","eveHdQW6GjCY4Chqytz":"EY71FHFvzbljG70f1","1TMIu7X2QyysZZ9YEn":"fEcRbhBKPo","cTJrl4Ww2h":"Md3pxcptB99RdQyEkFz","9iYhMQfNzoD":"dsOy7Z7n5MnNV"},"yfO6aI5P4d":{"Qj6iGgtD5izbnyOy":"pYOeTCuRrf5x6tU0Mm","5lUg51qAEDgFfCWr5":"hRNlSRKDl2r7","7JHzK50fgTIPvxf7":"7BdhZleN28","jhoIbEVzUgvI":"GFjFsRxrB65i3G6","LM7K47dC…
no.unit.nva.search.resource.ResourceClientAllScientificValuesTest ‑ [1] { "onlineIssn": "1903-6523" }
no.unit.nva.search.resource.ResourceClientAllScientificValuesTest ‑ [2] { "printIssn": "1903-6523" }
no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=ICorVcpTIaqeHfYPVG, documentIdentifier=null], resource={"M6sbZ5ZX8nKTKASb4z":{"QNmZ6ycH1oQOUyMnU":"5VugihxgRDCwJL93b","16HSSFOL0CJHS":"gwua9vDUqElrUK7ppD","xIyBTLpt14g8ke":"jPOFzCy1YwMZM","vKcc2Bo5xcIET0pRe":"bkewASdcTuRJdmk1mC","Pprc5e845yJ":"Zq4I3BpL5bJNT"},"SKbh0J7hU1yPZX":{"ViTGaZqzYihTs5tWMYz":"7xKGsOFBjz5vfN6T7","c6h6JRHUVOvWgJWioGN":"5viLeu0tNQAhh","EAJ1idDVC0wvFIW":"QQKA6m9AU7Rcj","xwQ91ma7Rzn39p7n":"H4mUxtPTJYA","LjY2ru0Fzew6MDay…
no.unit.nva.indexingclient.models.IndexDocumentTest ‑ should throw exception when validating and missing mandatory fields:IndexDocument[consumptionAttributes=EventConsumptionAttributes[index=null, documentIdentifier=019c0e9ebdb8-8745f7a1-fb53-4f2c-a5dd-c6fe0b955fb5], resource={"F3rss8fgGyZw":{"NNeJOjC1LPYRpdPIXEf":"zwtV2Z0ej1","ki79liNrxuWkbEGdCH":"IsH03NM4VeyAJq7Zet","s5xT0eMAIjqnlxrwYqF":"EUaJRqSoTbHDQi59","y9xCcbjtdckF":"w9vU2IR3Rx2320aewq","rfrzk0Xxc8iDGo6B5Eu":"iV3TYGCvUERi"},"mZDldyF8XNiqvfW":{"6ASpRj8rYEZ3A0n08":"uwJz25fQ5dPNG0xXwE","A1EWyistPb9J":"KMWq1jG4MxLCWgc","GSdNcPTgckXrSn3Vn":"QQuNGziIe9X","bDjGBOcV8i0VaVH7b":…
no.unit.nva.search.resource.ResourceClientAllScientificValuesTest ‑ [1] { "onlineIssn": "1903-6523" }

no.unit.nva.search.resource.ResourceClientAllScientificValuesTest ‑ [2] { "printIssn": "1903-6523" }

no.unit.nva.search.resource.ResourceClientAllScientificValuesTest ‑ shouldExcludeDocumentWhereParentPublicationTypeIsMissingWhenFilteringByExcludeParentTypeParameter()
no.unit.nva.search.resource.ResourceClientAllScientificValuesTest ‑ shouldExcludeDocumentsWhereParentPublicationTypeIsMissing()

♻️ This comment has been updated with latest results.

brinxmat
brinxmat previously approved these changes Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants