Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: don't allow special chars in user names. #5846

Merged
merged 1 commit into from
Oct 21, 2024
Merged

web: don't allow special chars in user names. #5846

merged 1 commit into from
Oct 21, 2024

Conversation

davidpanderson
Copy link
Contributor

Check this (and show appropriate message) in both account creation and user name update

@davidpanderson
web: don't allow special chars in user names.
3b1edd1 
Check this (and show appropriate message) in both account creation
and user name update
@AenBleidd AenBleidd requested a review from lfield October 11, 2024 09:36
@AenBleidd AenBleidd added this to the Server Release 1.6.0 milestone Oct 11, 2024
@AenBleidd
Copy link
Member

If I understand this correctly, this is a replacement for #5845.
@lfield, please take a look

@davidpanderson davidpanderson mentioned this pull request Oct 11, 2024
Closed
@lfield
Copy link
Contributor

lfield commented Oct 14, 2024

LGTM

@AenBleidd AenBleidd merged commit af2bf98 into master Oct 21, 2024
144 of 145 checks passed
@AenBleidd AenBleidd deleted the dpa_username branch October 21, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfield lfield Awaiting requested review from lfield

Assignees

@lfield lfield

Labels
C: Server - Setup P: Critical PR: Bugfix
Projects
Server
Status: Done
Milestone
Server Release 1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@davidpanderson @AenBleidd @lfield