Support splits in SYPD and ASYPD per job#196
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
==========================================
- Coverage 80.89% 80.86% -0.03%
==========================================
Files 109 109
Lines 9514 9545 +31
==========================================
+ Hits 7696 7719 +23
- Misses 1818 1826 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates various endpoints and job processing functions to include and utilize split-related information for SYPD and ASYPD calculations.
- Introduces split and splits attributes to jobs in pkl files and the database model.
- Updates performance calculations in utility functions and node representations in tree and graph components.
- Propagates the new attributes in job creation within the job factory.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| autosubmit_api/persistance/pkl_reader.py | Adds logic to extract split-related attributes from pkl data. |
| autosubmit_api/performance/utils.py | Updates SYPD/ASYPD calculations to account for splits and fixes a shebang typo. |
| autosubmit_api/experiment/common_requests.py | Passes the job.splits parameter during pkl data processing. |
| autosubmit_api/database/models.py | Extends the job model with split and splits attributes. |
| autosubmit_api/components/representations/tree/tree.py | Incorporates split/splits in node data and performance calculations. |
| autosubmit_api/components/representations/graph/graph.py | Adjusts performance function calls and node data to include split-related fields. |
| autosubmit_api/components/jobs/job_factory.py | Maps split attributes from the pkl model to runtime job objects. |
Comments suppressed due to low confidence (1)
autosubmit_api/performance/utils.py:1
- There is a typo in the shebang; please change 'pytthon' to 'python'.
#!/usr/bin/env pytthon
e3f06d3 to
4e037f6
Compare
4e037f6 to
7c1a69c
Compare
|
@LuiggiTenorioK is this the PR you mentioned in the last meeting for me to have a look/review? |
Hi @kinow. No, this is partially blocked until Autosubmit 4.2.0. The one that is pending for review is BSC-ES/autosubmit-gui#376 with #239 to enable the set status command in the BSC GUI. |
7c1a69c to
5f51203
Compare
88c418c to
f78425c
Compare
a695631 to
29c1b68
Compare
Closes: #170
This PR adds this information to the jobs in the
/v3/tree/{expid},/v3/graph/{expid},/v3/pklinfo/{expid}, and/v3/pkltreeinfo/{expid}:Then, the SYPD and ASYPD formula is updated to divide the numerator by the number of splits in the job group.
Unfortunately, since Autosubmit didn't support saving the split information in the historical DB, the job and experiment endpoints aren't updated and might have different SYPD/ASYPD values.