Skip to content

Add update description runner endpoint#293

Open
LuiggiTenorioK wants to merge 2 commits into
mainfrom
429-updt-descr-runner
Open

Add update description runner endpoint#293
LuiggiTenorioK wants to merge 2 commits into
mainfrom
429-updt-descr-runner

Conversation

@LuiggiTenorioK
Copy link
Copy Markdown
Member

@LuiggiTenorioK LuiggiTenorioK self-assigned this May 29, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 29, 2026

Codecov Report

❌ Patch coverage is 62.29508% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.76%. Comparing base (e4e3d7a) to head (3a2b0e6).

Files with missing lines Patch % Lines
autosubmit_api/runners/ssh_runner.py 13.33% 13 Missing ⚠️
autosubmit_api/runners/local_runner.py 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   80.89%   80.76%   -0.13%     
==========================================
  Files         109      109              
  Lines        9514     9570      +56     
==========================================
+ Hits         7696     7729      +33     
- Misses       1818     1841      +23     
Flag Coverage Δ
fast-tests 80.76% <62.29%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LuiggiTenorioK LuiggiTenorioK marked this pull request as ready for review June 4, 2026 12:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new v4 runner command endpoint to update an experiment’s description, wiring it through the router into runner implementations and adding endpoint-level tests. It extends the runner interface with an update_description capability and implements it for both local and SSH runners.

Changes:

  • Add /v4/runners/command/update-experiment-description endpoint guarded by runner endpoint configuration.
  • Implement update_description() in LocalRunner and SSHRunner, and add the method to the base Runner interface.
  • Add tests covering disabled endpoint, valid request, invalid profile, and runner failure.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
autosubmit_api/routers/v4/runners.py Adds the new update-experiment-description endpoint and endpoint category enum usage.
autosubmit_api/runners/base.py Extends the runner interface with update_description.
autosubmit_api/runners/local_runner.py Implements local execution of the autosubmit update-description command.
autosubmit_api/runners/ssh_runner.py Implements SSH execution of the autosubmit update-description command.
tests/test_endpoints_v4.py Adds tests validating the new endpoint behavior and error cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread autosubmit_api/runners/base.py
Comment thread autosubmit_api/runners/local_runner.py
Comment thread autosubmit_api/runners/ssh_runner.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an option to modify experiments descriptions

3 participants