Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous shader compilation in Babylon Native #13587

Merged
merged 11 commits into from
Mar 8, 2023

Conversation

glangstonb
Copy link
Contributor

@glangstonb glangstonb commented Mar 3, 2023

This code supports interfacing with a feature I wrote for Babylon Native allowing asynchronous shader compilation. It's intended to be reverse-compatible with Babylon Native as of commit 08cec4cacf4d187eb839b6318a7414860f8fde77 on master, but that version of Babylon Native doesn't have the asynchronous shader compilation yet; I will make another PR into Babylon Native with the necessary C++ code to support asynchronous shader compilation, and the shader compilation will be asynchronous only when both updates are used together.

Here's the issue on the Babylon Native side for this feature:
BabylonJS/BabylonNative#402

The PR for the Babylon Native side has now been opened:
BabylonJS/BabylonNative#1209

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 3, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@sebavan sebavan requested a review from bghgary March 3, 2023 23:32
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !!! but I am no native expert so let s wait on @bghgary review.

Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the error handling.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 3, 2023

Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bghgary bghgary enabled auto-merge (squash) March 8, 2023 01:49
@bghgary bghgary merged commit 2ef904c into BabylonJS:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants