Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with more recent Java and Node versions #640

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft
20 changes: 1 addition & 19 deletions .github/workflows/bn_master_commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
types: [babylonnative-master-update]

env:
BRN_Version: 0.64
BRN_Version: '0.69'

jobs:
build-android:
Expand All @@ -16,10 +16,6 @@ jobs:
uses: actions/[email protected]
with:
submodules: 'recursive'
- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16
- name: Setup CMake
uses: jwlawson/[email protected]
with:
Expand All @@ -35,12 +31,6 @@ jobs:
- name: NPM Install (Binary Package)
run: npm install
working-directory: ./Package
- name: Setup Java
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '17'
check-latest: true
- name: Gulp (Android)
run: npx gulp buildAndroid
working-directory: ./Package
Expand All @@ -55,10 +45,6 @@ jobs:
uses: actions/[email protected]
with:
submodules: 'recursive'
- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16
- name: NPM Install (Playground)
run: npm install
working-directory: ./Apps/Playground
Expand Down Expand Up @@ -86,10 +72,6 @@ jobs:
submodules: 'true'
- name: Setup MSBuild
uses: microsoft/[email protected]
- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16
- name: Setup NuGet
uses: nuget/setup-nuget@v1
with:
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/ios_android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ jobs:
uses: actions/[email protected]
with:
submodules: 'recursive'
- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16
- name: Setup CMake
uses: jwlawson/[email protected]
with:
Expand All @@ -33,12 +29,6 @@ jobs:
run: brew install ninja
- name: 'Select XCode ${{ inputs.xcode-version }}'
run: sudo xcode-select --switch /Applications/Xcode_${{ inputs.xcode-version }}.app/Contents/Developer
- name: Setup Java
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '17'
check-latest: true
- name: NPM Install (Playground)
run: npm install
working-directory: ./Apps/Playground
Expand Down
30 changes: 1 addition & 29 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
branches:
- master
env:
BRN_Version: '0.64'
BRN_Version: '0.70'

jobs:
build-android:
Expand All @@ -14,10 +14,6 @@ jobs:
uses: actions/[email protected]
with:
submodules: 'recursive'
- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16
- name: Setup CMake
uses: jwlawson/[email protected]
with:
Expand All @@ -33,12 +29,6 @@ jobs:
- name: NPM Install (Binary Package)
run: npm install
working-directory: ./Package
- name: Setup Java
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '17'
check-latest: true
- name: Gulp (Android)
run: npx gulp buildAndroid
working-directory: ./Package
Expand Down Expand Up @@ -90,10 +80,6 @@ jobs:
uses: actions/[email protected]
with:
submodules: 'recursive'
- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16
- name: NPM Install (Playground)
run: npm install
working-directory: ./Apps/Playground
Expand Down Expand Up @@ -139,22 +125,12 @@ jobs:
uses: actions/[email protected]
with:
submodules: 'recursive'
- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16
- name: Setup CMake
uses: jwlawson/[email protected]
with:
cmake-version: '3.26.3'
- name: Setup Ninja
run: brew install ninja
- name: Setup Java
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '17'
check-latest: true
- name: NPM Install (Playground)
run: npm install
working-directory: ./Apps/Playground
Expand Down Expand Up @@ -185,10 +161,6 @@ jobs:
submodules: 'true'
- name: Setup MSBuild
uses: microsoft/[email protected]
- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16
- name: Setup NuGet
uses: nuget/setup-nuget@v1
with:
Expand Down
12 changes: 0 additions & 12 deletions .github/workflows/test_version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,6 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ github.event.inputs.Node_Version }}
- name: Setup Java
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '17'
check-latest: true
- name: Build Playground Android
run: |
npm uninstall -g react-native-cli @react-native-community/cli
Expand Down Expand Up @@ -143,12 +137,6 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ github.event.inputs.Node_Version }}
- name: Setup Java
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '17'
check-latest: true
- name: Build Playground Android
run: |
npm uninstall -g react-native-cli @react-native-community/cli
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/typescript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ jobs:
uses: actions/[email protected]
with:
submodules: 'recursive'
- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16
- name: NPM Install (Playground)
run: npm install
working-directory: ./Apps/Playground
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ jobs:
submodules: 'true'
- name: Setup MSBuild
uses: microsoft/[email protected]
- name: Setup Node 16
uses: actions/setup-node@v3
with:
node-version: 16
- name: Setup NuGet
uses: nuget/setup-nuget@v1
with:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
3 changes: 3 additions & 0 deletions Apps/Playground/0.64/android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@ android.enableJetifier=true

# Version of flipper SDK to use with React Native
FLIPPER_VERSION=0.54.0

#https://docs.gradle.org/nightly/userguide/upgrading_version_7.html#legacy_incrementaltaskinputs_api
android.experimental.legacyTransform.forceNonIncremental=true
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
3 changes: 3 additions & 0 deletions Apps/Playground/0.65/android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@ android.enableJetifier=true

# Version of flipper SDK to use with React Native
FLIPPER_VERSION=0.93.0

#https://docs.gradle.org/nightly/userguide/upgrading_version_7.html#legacy_incrementaltaskinputs_api
android.experimental.legacyTransform.forceNonIncremental=true
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
3 changes: 3 additions & 0 deletions Apps/Playground/0.69/android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,6 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
# to write custom TurboModules/Fabric components OR use libraries that
# are providing them.
newArchEnabled=false

#https://docs.gradle.org/nightly/userguide/upgrading_version_7.html#legacy_incrementaltaskinputs_api
android.experimental.legacyTransform.forceNonIncremental=true
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
7 changes: 0 additions & 7 deletions Apps/Playground/0.69/windows/Playground/Playground.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,4 @@
<ImportGroup Label="ReactNativeWindowsTargets">
<Import Project="$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.Uwp.CppApp.targets" Condition="Exists('$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.Uwp.CppApp.targets')" />
</ImportGroup>
<Target Name="EnsureReactNativeWindowsTargets" BeforeTargets="PrepareForBuild">
<PropertyGroup>
<ErrorText>This project references targets in your node_modules\react-native-windows folder that are missing. The missing file is {0}.</ErrorText>
</PropertyGroup>
<Error Condition="!Exists('$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.Uwp.CppApp.props')" Text="$([System.String]::Format('$(ErrorText)', '$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.Uwp.CppApp.props'))" />
<Error Condition="!Exists('$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.Uwp.CppApp.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(ReactNativeWindowsDir)\PropertySheets\External\Microsoft.ReactNative.Uwp.CppApp.targets'))" />
</Target>
</Project>
3 changes: 3 additions & 0 deletions Apps/Playground/0.70/android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,6 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
# to write custom TurboModules/Fabric components OR use libraries that
# are providing them.
newArchEnabled=false

#https://docs.gradle.org/nightly/userguide/upgrading_version_7.html#legacy_incrementaltaskinputs_api
android.experimental.legacyTransform.forceNonIncremental=true
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading
Loading