-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: RNTA linking issue #654
base: master
Are you sure you want to change the base?
Conversation
fd3ce3e
to
662c1e4
Compare
Hey, I've opened a PR to RNTA to add support for this feature: microsoft/react-native-test-app#2204 |
I'm working on fixing the build so we can continue testing this PR. #657 |
@okwasniewski I just merged the build fix PR. You should be able to update your PR and kick a new build. I'll check its progress |
662c1e4
to
04d33dd
Compare
04d33dd
to
944b1ab
Compare
I'm still encountering some issues with react-native-permissions when launching the app. Im going to go back to this tomorrow, so let's wait with merging 🙏 (At least the app is now properly built) |
Okay, so I got this to work on the simulator, there was an issue with The only thing left is that the Playground is still not building properly for real device (same issue as before). Going to focus on this one now. |
c8b1673
to
7bba3db
Compare
Describe the change
This PR fixes RNTA linking issues for newer versions of CMake, this PR is still a draft as I needed to patch-package the react-native-test-app. I need to make sure this is the correct solution to solve this issue and contribute the fix back to RNTA.
Screenshots
If applicable, add screenshots to help explain your change. Consider using tools like Giphy Capture or ScreenToGif to capture animated gifs. If you are using physical devices rather than emulators/simulators, consider using tools like Vysor or scrcpy to project your device's display to your dev machine to allow for screen capture.
Documentation
Have you updated the documentation to reflect your changes? (Yes or N/A)
Testing
Have you tested the final iteration of your changes? (Yes or N/A or I need help testing on [Android|iOS|Windows])