Add basic layout and stub out components #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very large commit that collates many smaller incremental commits and accomplishes the following: * Replaces prototype styling/layout with new styling/layout based on high-fidelity designs * Begins implementation of additional features and UX * Refactors components and adds new component stubs * Replaces separate stylesheet with styled-components This is just the beginning. Closes #30 and #31
reefdog
force-pushed
the
30-31-layout-and-stubs
branch
from
4934746
to
c532075
Compare
slifty
approved these changes
Mar 7, 2019
slifty
added a commit
that referenced
this pull request
Mar 14, 2019
This follows the first few steps in the [Apollo Documentation](https://www.apollographql.com/docs/graphql-subscriptions/subscriptions-to-schema.html) for adding subscriptions to graphql. It sets up the schema to handle subscriptions and also creates the very initial integration with the PubSub implementation baked into the graphql-subscriptions library. As noted in that library, it is only appropriate for demos, not production. We will eventually want to replace it with a more robust PubSub implementation. Issue #44 Issue #43
slifty
added a commit
that referenced
this pull request
Mar 14, 2019
This follows the first few steps in the [Apollo Documentation](https://www.apollographql.com/docs/graphql-subscriptions/subscriptions-to-schema.html) for adding subscriptions to graphql. It sets up the schema to handle subscriptions and also creates the very initial integration with the PubSub implementation baked into the graphql-subscriptions library. As noted in that library, it is only appropriate for demos, not production. We will eventually want to replace it with a more robust PubSub implementation. Issue #44 Issue #43
slifty
added a commit
that referenced
this pull request
Mar 14, 2019
This follows the first few steps in the [Apollo Documentation](https://www.apollographql.com/docs/graphql-subscriptions/subscriptions-to-schema.html) for adding subscriptions to graphql. It sets up the schema to handle subscriptions and also creates the very initial integration with the PubSub implementation baked into the graphql-subscriptions library. As noted in that library, it is only appropriate for demos, not production. We will eventually want to replace it with a more robust PubSub implementation. Issue #44 Issue #43
slifty
added a commit
that referenced
this pull request
Mar 14, 2019
Subscriptions are the goal, since they are likely much more efficient and scale, but for the purposes of a demo we think that just using built in polling functionality of ApolloClient will do the trick. Issue #44
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very large commit that collates many smaller incremental commits and accomplishes the following:
This is just the beginning.
Closes #30 and #31