fix: regex_search should respect use_ckignore option #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex_search function was hardcoding use_ckignore to true, ignoring the user's choice in SearchOptions. This prevented the --no-ckignore CLI flag from working correctly in regex search mode. This bug was discovered by the integration test test_no_ckignore_flag_disables_hierarchical_ignore.
Adds 7 new tests (300+ lines) to verify the hierarchical .ckignore behavior added in the previous commits: Integration tests (ck-cli): - test_no_ckignore_flag_disables_hierarchical_ignore: Verifies --no-ckignore CLI flag properly disables .ckignore filtering in regex search mode Engine tests (ck-engine): - test_multiple_ckignore_files_merge_correctly: Verifies multiple .ckignore files at parent, subdir, and deeper levels all apply correctly Index tests (ck-index): - test_ckignore_works_without_gitignore: Verifies .ckignore works independently when respect_gitignore=false Core tests (ck-core): - test_build_exclude_patterns_with_defaults: Tests pattern merging with defaults enabled - test_build_exclude_patterns_without_defaults: Tests pattern handling with defaults disabled - test_build_exclude_patterns_empty_additional: Tests behavior with empty additional patterns - test_read_ckignore_edge_cases: Tests edge cases including empty files, comments only, whitespace, and mixed content All tests pass. Total test count now 149 (was 142).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for not including this in the original PR, but I asked claude for a few additional tests and got a free bugfix.