Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG FIX] Fix for Issue #19. Fixes crashes on iOS 5.0, where calls to NS... #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ruohoruotsi
Copy link

..._AVAILABLE_IOS(6_0) methods were not protected by instancesRespondToSelector checks. #19

…alls to NS_AVAILABLE_IOS(6_0) methods were not protected by instancesRespondToSelector checks. BeamApp#19
@HBehrens
Copy link
Member

Thanks, Ruoho. Did you check how this impacts the theming on iOS5?

@ruohoruotsi
Copy link
Author

Hi Heiko,
This does not affect themes/theming, as these calls are iOS6 only. This code only prevents invocation of such calls to an API (iOS6) newer than the minimum deployment target (iOS5).

I followed the directions here:
https://developer.apple.com/library/mac/documentation/DeveloperTools/Conceptual/cross_development/Using/using.html

I currently have an iPad 1 running 5.1.1. I saw this issue immediately because these calls are not supported on iOS5 (which is currently the minimum deployment target). This is a non-issue for any iOS6 system. I hope this helps. Let me know if you need any more information or concerns about this commit.

cheers,
RR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants