Skip to content

fix : dot removing when last digit is erased #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix : dot removing when last digit is erased #550

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00886f8
fix dot removing when last digit is erased
dylanflandpro Dec 26, 2024
8f89466
fix keyboard change
dylanflandpro Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/components/InputNumber/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export const InputNumber = forwardRef<InputNumberProps, 'input'>(
});
const [isFocused, setIsFocused] = useState(false);
const tmpValueRef = useRef(value ?? defaultValue ?? null);
const [rawInput, setRawInput] = useState<string | undefined>(undefined);

const handleOnKeyDown = (e: KeyboardEvent<HTMLInputElement>) => {
const v = tmpValueRef.current;
Expand All @@ -86,10 +87,20 @@ export const InputNumber = forwardRef<InputNumberProps, 'input'>(
onChange(v);
}
if (e.key === 'ArrowUp') {
onChange(clamp((v ?? 0) + (e.shiftKey ? bigStep : step), { min, max }));
const newValue = clamp((v ?? 0) + (e.shiftKey ? bigStep : step), {
min,
max,
});
setRawInput(String(newValue));
onChange(newValue);
}
if (e.key === 'ArrowDown') {
onChange(clamp((v ?? 0) - (e.shiftKey ? bigStep : step), { min, max }));
const newValue = clamp((v ?? 0) - (e.shiftKey ? bigStep : step), {
min,
max,
});
onChange(newValue);
setRawInput(String(newValue));
}
rest.onKeyDown?.(e);
};
Expand All @@ -104,10 +115,10 @@ export const InputNumber = forwardRef<InputNumberProps, 'input'>(
prefix: `${currency ? currencyPrefix : ''}${prefix}`,
onValueChange: (values) => {
tmpValueRef.current = values.floatValue ?? null;
setRawInput(values.value);

// Prevent -0 to be replaced with 0 when input is controlled
if (values.floatValue === 0) return;

onChange(values.floatValue ?? null);
},
} satisfies ComponentProps<typeof NumericFormat>;
Expand All @@ -120,7 +131,7 @@ export const InputNumber = forwardRef<InputNumberProps, 'input'>(
pe={showButtons ? 8 : undefined}
{...rest}
{...getNumericFormatOptions}
value={value === undefined ? undefined : value ?? ''}
value={rawInput ?? (value === undefined ? undefined : value ?? '')}
defaultValue={defaultValue ?? undefined}
placeholder={
typeof placeholder === 'number'
Expand Down
Loading