Update 1.6.2 #347
Merged
Update 1.6.2 #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrectly, which prevented it from setting up tmp files in some cases on Windows.
Member
Author
|
I created a PR for the original repository here otiai10/copy#176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hotfix for Regolith failing to copy junctions.
Regolith
1.6was updated to Go1.25from Go1.18. Go1.23changed the behavior of theos.FileInfo. Now the the junctions no longer have theos.ModeSymlinkbit set. This change in behavior caused errors when trying to copy junctions using thegithub.com/otiai10/copylirbary (that provides a deep directory copy functionallity).The fix is a temporary solution, where we use our own, updated version of the library to restore the old behavior, form before Go 1.23.