Skip to content

Fixes for Windows #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes for Windows #143

wants to merge 2 commits into from

Conversation

Ace314159
Copy link

This fixes the build for Windows.

Here is a short summary of the changes:

  • Vcpkg uses the libzmq target, so if that target exists, I use that instead
  • Windows requires exporting symbols when making shared libraries

@Ace314159
Fix FindZMQ on Windows
a900ef1 
Use vcpkg target
@Ace314159
Fix Windows build
4d826fd 
Export symbols and manual visibility for static members
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ace314159