Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add disabled prop to the tags-input component #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lsherman98
Copy link

No description provided.

@BelkacemYerfa
Copy link
Owner

Hello @lsherman98

Thanks for your contributions, just want to ask if i get it right, is the disabled is a flag to to disable access the use of the tags input globally?

@lsherman98
Copy link
Author

@BelkacemYerfa Not sure what you mean by globally? I needed a way to disable the tags input by passing in a boolean similar to most other inputs. Not sure if how i went about it is the proper way so let me know if there is something else i should add.

@BelkacemYerfa BelkacemYerfa self-assigned this Feb 1, 2025
@BelkacemYerfa
Copy link
Owner

@lsherman98, thanks for clarifying the confusion, that's exactly what i meant, by globally.
The code seems fine, but to fully merge this pr, you need to add the new property into the the docs in the property table that exists in the documentation of the tags-input component, you will find it here, after that run the build and do local testing if there is any issue regardless the rules of mdx.
After this is done your PR will get merged into the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants