Updated README.md to align with latest build #462
Conversation
|
|
||
| /// <summary> | ||
| /// Flat Armor value for the object. | ||
| /// </summary> |
There was a problem hiding this comment.
could you remove this commit as it's already been merged?
There was a problem hiding this comment.
You should be able to do so with a git rebase origin/develop if origin is the name of this remote.
There was a problem hiding this comment.
You'll have to excuse my lack of knowledge, but I used that command to no avail. the remote is named origin. Any advice?
There was a problem hiding this comment.
Probably causing more problems than I'm solving :)
README.md
Outdated
| } | ||
| catch (RiotSharpException ex) | ||
| { | ||
| // Handle the exception however you want. | ||
| } | ||
| ``` | ||
|
|
||
| To get the stats in ranked for a specific champion for this summoner: | ||
| **(DEPRECATED)** To get the stats in ranked for a specific champion for this summoner: |
There was a problem hiding this comment.
I think we can remove the whole paragraph since people won't be able to do it.
|
Will make these changes, it may be a bit. A tad busy |
|
Well at the very least, it seems that the commit still exists... however it isn't saying it is a changed file. I'm not sure if that's sufficient. Also deleted that blurb on the ranked stats. |
|
awesome, thanks for the heads up |
|
Usually it's good practice to have a different branch for each pull request, the flow boils down to: git checkout develop
git pull upstream develop # to have a up-to-date copy of develop
git checkout -b my-fix # creates a new branch dedicated to the fix
... |
Note: for some reason it isn't seeing the change to StatsStatic.cs from before :/