fix return type for getRefreshTokenGrant phpdoc #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if someone wants to use a custom refreshable grant type and implement this interface, then the code will fail some validation because the expected return type (inferred from the phpdoc @return) will not pass. I think it would be better to remove this phpdoc @return because the function uses explicit typing system from PHP, however this will fix it too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if someone wants to use a custom refreshable grant type and implement this interface, then the code will fail some validation because the expected return type (inferred from the phpdoc @return) will not pass. I think it would be better to remove this phpdoc @return because the function uses explicit typing system from PHP, however this will fix it too