Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed onWillPop assert error #309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yu1ro
Copy link

@yu1ro yu1ro commented Oct 9, 2022

fix #308

@ayoubm
Copy link

ayoubm commented Oct 10, 2022

@BilalShahid13 can you please merge this PR? It's needed for the willPopScope to work properly.

Thank you!

@pishguy
Copy link

pishguy commented Nov 9, 2022

@yu1ro +1

@htunlin-kitesense
Copy link

Hello, can help merge this PR? willPopScope not working properly in PersistentTabView.custom.

@danielcabral-code
Copy link

Hey, would be nice if someone could merge this please. As @htunlin-kitesense mentioned, PersistentTabView.custom is currently impossible to use.

@AndreSait
Copy link

AndreSait commented Apr 26, 2023

In flutter 3.7.8, the onWillPop creates some casting problems, which can be fixed by changing it to this:

onWillPop: !widget.handleAndroidBackButtonPress && widget.onWillPop != null ? () async { final result = await widget.onWillPop!(_contextList[_controller!.index]); return Future.value(result); }

@pupubird
Copy link

pupubird commented Jul 6, 2023

Please help to merge this PR :c

@pupubird
Copy link

For anyone ever come to this issue, here's the V2 that's actively maintained https://pub.dev/packages/persistent_bottom_nav_bar_v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onWillPop is not working properly
8 participants