-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed onWillPop assert error #309
base: master
Are you sure you want to change the base?
Conversation
@BilalShahid13 can you please merge this PR? It's needed for the willPopScope to work properly. Thank you! |
@yu1ro +1 |
Hello, can help merge this PR? willPopScope not working properly in PersistentTabView.custom. |
Hey, would be nice if someone could merge this please. As @htunlin-kitesense mentioned, PersistentTabView.custom is currently impossible to use. |
In flutter 3.7.8, the onWillPop creates some casting problems, which can be fixed by changing it to this:
|
Please help to merge this PR :c |
For anyone ever come to this issue, here's the V2 that's actively maintained https://pub.dev/packages/persistent_bottom_nav_bar_v2 |
fix #308