Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add how-to-load-gene-from-gff #6

Merged
merged 6 commits into from
Feb 17, 2025
Merged

Conversation

jdrnevich
Copy link
Collaborator

No description provided.

@csoneson
Copy link
Collaborator

csoneson commented Feb 14, 2025

Thanks Jenny! Three small comments:

  • There is a missing comma between txdbmaker and mzR in the DESCRIPTION file
  • On line 29, there is a "The a standardized file format" - both "The" and "a" are not needed
  • What do you think about using r Biocpkg("...") instead of explicitly putting the links to Bioc package landing pages (e.g. *[txdbmaker](https://bioconductor.org/packages/release/bioc/html/txdbmaker.html)*)?

@jdrnevich
Copy link
Collaborator Author

jdrnevich commented Feb 14, 2025

Thanks for finding all the little edits. And I didn't know about r Biocpkg("...") - this is much easier! I made the changes and updated the pull request. Hopefully it was the missing comma in the DESCRIPTION that was causing the previous fail.

@csoneson
Copy link
Collaborator

Sorry, I missed that there seems to be one more comma missing in the DESCRIPTION file (in the author list)

@jdrnevich
Copy link
Collaborator Author

Ugh - I had them all correct when I did it, but Laurent and Pedro had pushed theirs after I forked, so I had to merge the changes and didn't notice that I had to add commas again. Hopefully 3rd time is the charm!

@csoneson csoneson merged commit ed2d5ad into Bioconductor:devel Feb 17, 2025
1 check passed
@csoneson
Copy link
Collaborator

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants