orientation-screen: Migrate to rust #1631
Conversation
NickeZ
force-pushed
the
maint/migrate-orientation-screen-to-rust
branch
17 times, most recently
from
97edacf to
39c79ca
Compare
create an async friendly hardware supported delayin C and wrap it in rust using Future.
NickeZ
force-pushed
the
maint/migrate-orientation-screen-to-rust
branch
from
39c79ca to
781d4b1
Compare
| orientation_arrows.screen_stack_push(); | ||
|
|
||
| // Wait until orientation has been chosen | ||
| option_no_screensaver(&result).await; |
There was a problem hiding this comment.
I think you want option not option_no_screensaver. The screensaver should become active in the orientation screen. It may be the most likely to actually burn in the screen, e.g. when connected and left plugged in.
| // Switch to lockscreen that shows "See the bitbox app" and device name | ||
| bitbox02::ui::screen_process_waiting_switch_to_lockscreen(); | ||
|
|
||
| orientation_selected_cb(); |
There was a problem hiding this comment.
Did a double take seeing a callback called at the end of an async function. Would it be possible to simply return whatever value you need and use it when polling is done (in if let Poll::Ready(result) = result { ... )
There was a problem hiding this comment.
I don't think so because this future isn't run in a traditional async runtime, it is run with our "glue layer". I could return the callback and then call it in the rust_workflow_spin() function instead. But not sure if that is great.
I was hoping it would be helpful if the orientation workflow was in rust for the simulator. But in the end it didn't play out so well, I still have to call the glue-layer because I don't have a proper async runtime in the simulator either.
There was a problem hiding this comment.
(the rust version of the orientation selection is still more readable IMO than the c version with interrupts, so I still think it is a net win.)
NickeZ
force-pushed
the
maint/migrate-orientation-screen-to-rust
branch
from
7d78b67 to
fece219
Compare
2 participants
create an async friendly hardware supported delayin C and wrap it in rust using Future.