Skip to content

Conversation

ravibitgo
Copy link
Contributor

@ravibitgo ravibitgo commented Sep 29, 2025

Ticket: COIN-5805

@ravibitgo ravibitgo force-pushed the COIN-5805 branch 7 times, most recently from 8438ca1 to 3b84455 Compare September 30, 2025 09:13
borkds
borkds previously approved these changes Sep 30, 2025
Copy link
Contributor

@borkds borkds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@borkds
Copy link
Contributor

borkds commented Sep 30, 2025

should we maintain any documentation here?

@ravibitgo ravibitgo requested review from baltiyal and borkds October 1, 2025 09:06
@baltiyal baltiyal marked this pull request as ready for review October 1, 2025 09:07
@baltiyal baltiyal requested review from a team as code owners October 1, 2025 09:07
baltiyal
baltiyal previously approved these changes Oct 1, 2025
Copy link
Contributor

@baltiyal baltiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

borkds
borkds previously approved these changes Oct 1, 2025
import { Bsv, Tbsv } from '@bitgo/sdk-coin-bsv';
import { Btc, Tbtc, Tbtcsig, Tbtc4, Tbtcbgsig } from '@bitgo/sdk-coin-btc';
import { Btg } from '@bitgo/sdk-coin-btg';
import { Canton, TCanton } from '@bitgo/sdk-coin-canton';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { Canton, TCanton } from '@bitgo/sdk-coin-canton';
import { Canton, Tcanton } from '@bitgo/sdk-coin-canton';

lets follow the same notation as other coins

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@ravibitgo ravibitgo dismissed stale reviews from borkds and baltiyal via 669c086 October 1, 2025 12:31
baltiyal
baltiyal previously approved these changes Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants