-
Notifications
You must be signed in to change notification settings - Fork 300
feat(sdk-coin-canton): added new coin, canton skeleton #7114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
8438ca1
to
3b84455
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
should we maintain any documentation here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
modules/bitgo/src/v2/coins/index.ts
Outdated
import { Bsv, Tbsv } from '@bitgo/sdk-coin-bsv'; | ||
import { Btc, Tbtc, Tbtcsig, Tbtc4, Tbtcbgsig } from '@bitgo/sdk-coin-btc'; | ||
import { Btg } from '@bitgo/sdk-coin-btg'; | ||
import { Canton, TCanton } from '@bitgo/sdk-coin-canton'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { Canton, TCanton } from '@bitgo/sdk-coin-canton'; | |
import { Canton, Tcanton } from '@bitgo/sdk-coin-canton'; |
lets follow the same notation as other coins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Ticket: COIN-5805