-
Notifications
You must be signed in to change notification settings - Fork 300
feat(statics): add polyx tokens #7143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is here 'tpolyx:0xa0ce6bc4c60981e08eca6504656c99e6'
, it should be polyx:0xa0ce6bc4c60981e08eca6504656c99e6
? it is a prod token right
can you please re check once
UnderlyingAsset['tpolyx:RAND176TM'], | ||
POLYX_TOKEN_FEATURES | ||
), | ||
polyxToken( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on existing patterns we first write prod token followed by test tokens
), | ||
polyxToken( | ||
'4121c583-2e0f-4d4c-95de-24b2a3f77181', | ||
'tpolyx:0xa0ce6bc4c60981e08eca6504656c99e6', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is here 'tpolyx:0xa0ce6bc4c60981e08eca6504656c99e6',
it should be polyx:0xa0ce6bc4c60981e08eca6504656c99e6
? it is a prod token right
'tpolyx:0xa0ce6bc4c60981e08eca6504656c99e6', | ||
'RAND175TM', | ||
6, | ||
'', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the ''
can't we write 'RAND175TM'
, suggested based on existing patterns?
TICKET: WIN-7452