Skip to content

Conversation

nvrakesh06
Copy link
Contributor

TICKET: WIN-7452

@nvrakesh06 nvrakesh06 marked this pull request as ready for review October 1, 2025 12:15
@nvrakesh06 nvrakesh06 requested review from a team as code owners October 1, 2025 12:15
Copy link
Contributor

@MohammedRyaan786 MohammedRyaan786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@damodarnaik699 damodarnaik699 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is here 'tpolyx:0xa0ce6bc4c60981e08eca6504656c99e6', it should be polyx:0xa0ce6bc4c60981e08eca6504656c99e6? it is a prod token right

can you please re check once

UnderlyingAsset['tpolyx:RAND176TM'],
POLYX_TOKEN_FEATURES
),
polyxToken(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on existing patterns we first write prod token followed by test tokens

),
polyxToken(
'4121c583-2e0f-4d4c-95de-24b2a3f77181',
'tpolyx:0xa0ce6bc4c60981e08eca6504656c99e6',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is here 'tpolyx:0xa0ce6bc4c60981e08eca6504656c99e6', it should be polyx:0xa0ce6bc4c60981e08eca6504656c99e6? it is a prod token right

'tpolyx:0xa0ce6bc4c60981e08eca6504656c99e6',
'RAND175TM',
6,
'',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the '' can't we write 'RAND175TM', suggested based on existing patterns?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants